Add Danish Discourse dataset #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KennethEnevoldsen
approved these changes
Mar 15, 2024
There was a problem hiding this comment.
Looks good!
Generally, I would like a performance metric on some models as well (but we already looked over those).
@imenelydiaker adding you as a reviewer as well.
KennethEnevoldsen
requested changes
Mar 15, 2024
Co-authored-by: Kenneth Enevoldsen <[email protected]>
Co-authored-by: Kenneth Enevoldsen <[email protected]>
| from datasets import load_dataset | ||
| from sentence_transformers import SentenceTransformer | ||
|
|
||
| from mteb.abstasks.AbsTaskClassification import AbsTaskClassification |
There was a problem hiding this comment.
Suggested change
| from mteb.abstasks.AbsTaskClassification import AbsTaskClassification | |
| from ...abstasks import AbsTaskClassification |
There was a problem hiding this comment.
Any reason to prefer this?
Co-authored-by: Imene Kerboua <[email protected]>
Co-authored-by: Imene Kerboua <[email protected]>
Co-authored-by: Imene Kerboua <[email protected]>
KennethEnevoldsen
approved these changes
Mar 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Awaiting license from @KennethEnevoldsen. Feel free to nitpick, want to do this right 👍