Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial implementation of co-located templates RFC. #249

Merged
merged 34 commits into from
Sep 24, 2019
Merged

Initial implementation of co-located templates RFC. #249

merged 34 commits into from
Sep 24, 2019

Commits on Aug 10, 2019

  1. Initial spike of co-located templates RFC. 

    Still quite WIP, but "basically works" when using ember-cli master which includes

ember-cli/ember-cli@84c449a

Co-authored-by: Robert Jackson <[email protected]>
    @chancancode @rwjblue
    chancancode and rwjblue committed Aug 10, 2019
    Configuration menu
    Copy the full SHA
    fbda2e0 View commit details
    Browse the repository at this point in the history

  2. Use globals for now 

    (blocked by ember-cli/ember-rfc176-data#164)
    @chancancode
    chancancode committed Aug 10, 2019
    Configuration menu
    Copy the full SHA
    764615e View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2019

  1. Fix addon compilation

    @chancancode
    chancancode committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    a640658 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2019

  1. Better error for missing default export

    @chancancode
    chancancode committed Aug 13, 2019
    Configuration menu
    Copy the full SHA
    4c6017b View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2019

  1. v3.2.0-alpha.0

    @chancancode
    chancancode committed Aug 22, 2019
    Configuration menu
    Copy the full SHA
    942c301 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2019

  1. Fix some Node 8 issues

    @chancancode
    chancancode committed Aug 24, 2019
    Configuration menu
    Copy the full SHA
    66dff2f View commit details
    Browse the repository at this point in the history

  2. Fix lint

    @chancancode
    chancancode committed Aug 24, 2019
    Configuration menu
    Copy the full SHA
    b9295c5 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2019

  1. Extract ColocatedTemplateProcessor to dedicated file.

    @rwjblue
    rwjblue committed Sep 5, 2019
    Configuration menu
    Copy the full SHA
    6b5a4d6 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into colocation

    @rwjblue
    rwjblue committed Sep 5, 2019
    Configuration menu
    Copy the full SHA
    10e5f31 View commit details
    Browse the repository at this point in the history

  3. Update linting config to allow async functions. 

    We can now rely on Node 8+, so this is "safe".
    @rwjblue
    rwjblue committed Sep 5, 2019
    Configuration menu
    Copy the full SHA
    3aabb50 View commit details
    Browse the repository at this point in the history

  4. Add broccoli-debug logging. 

    Running `BROCCOLI_DEBUG=ember-cli-htmlbars:* ember b` will now emit
files into `DEBUG/ember-cli-htmlbars/` showing the various stages of
compilation (input, after colocation processing, and final output).
    @rwjblue
    rwjblue committed Sep 5, 2019
    Configuration menu
    Copy the full SHA
    d7a579b View commit details
    Browse the repository at this point in the history

  5. Start fleshing out basic testing infrastructure.

    @rwjblue
    rwjblue committed Sep 5, 2019
    Configuration menu
    Copy the full SHA
    f7f3f47 View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'origin/master' into colocation

    @rwjblue
    rwjblue committed Sep 5, 2019
    Configuration menu
    Copy the full SHA
    1dbfb87 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2019

  1. Merge remote-tracking branch 'origin/master' into colocation

    @rwjblue
    rwjblue committed Sep 9, 2019
    Configuration menu
    Copy the full SHA
    6ba80f4 View commit details
    Browse the repository at this point in the history

  2. yarn lint:js --fix 

    Mostly fixes prettier
    @rwjblue
    rwjblue committed Sep 9, 2019
    Configuration menu
    Copy the full SHA
    24e8ad6 View commit details
    Browse the repository at this point in the history

  3. Extract helper method to build merged component JS contents. 

    Makes testing easier (at least it makes my mental overhead somewhat less
while testing 😀)
    @rwjblue
    rwjblue committed Sep 9, 2019
    Configuration menu
    Copy the full SHA
    fb2808a View commit details
    Browse the repository at this point in the history

  4. Add TODO comments for additional tasks.

    @rwjblue
    rwjblue committed Sep 9, 2019
    Configuration menu
    Copy the full SHA
    f5a0b01 View commit details
    Browse the repository at this point in the history

  5. Flesh out more tests.

    @rwjblue
    rwjblue committed Sep 9, 2019
    Configuration menu
    Copy the full SHA
    6de52e5 View commit details
    Browse the repository at this point in the history

  6. Avoid adding the import for setComponentTemplate. 

    This will be done by an AST plugin instead.
    @rwjblue
    rwjblue committed Sep 9, 2019
    Configuration menu
    Copy the full SHA
    5709c0f View commit details
    Browse the repository at this point in the history

  7. yarn lint:js --fix

    @rwjblue
    rwjblue committed Sep 9, 2019
    Configuration menu
    Copy the full SHA
    b44e14b View commit details
    Browse the repository at this point in the history

  8. Fix colocated-broccoli-plugin tests

    @rwjblue
    rwjblue committed Sep 9, 2019
    Configuration menu
    Copy the full SHA
    bb4ad58 View commit details
    Browse the repository at this point in the history

  9. Add babel plugin to add setComponentTemplate usage.

    @rwjblue
    rwjblue committed Sep 9, 2019
    Configuration menu
    Copy the full SHA
    9362a4c View commit details
    Browse the repository at this point in the history

  10. Simplify implementation / reduce duplication.

    @rwjblue
    rwjblue committed Sep 9, 2019
    Configuration menu
    Copy the full SHA
    952287b View commit details
    Browse the repository at this point in the history

  11. Make requires more lazy. 

    No need to require / load build related things when not building...
    @rwjblue
    rwjblue committed Sep 9, 2019
    Configuration menu
    Copy the full SHA
    cfa93e3 View commit details
    Browse the repository at this point in the history

  12. Add proper guard for using colocation.

    @rwjblue
    rwjblue committed Sep 9, 2019
    Configuration menu
    Copy the full SHA
    eba43a7 View commit details
    Browse the repository at this point in the history

  13. Refactor registry toTree setup.

    @rwjblue
    rwjblue committed Sep 9, 2019
    Configuration menu
    Copy the full SHA
    99ac97d View commit details
    Browse the repository at this point in the history

  14. Tweak comments in colocated-broccoli-plugin.

    @rwjblue
    rwjblue committed Sep 9, 2019
    Configuration menu
    Copy the full SHA
    60b8ae9 View commit details
    Browse the repository at this point in the history

  15. Ensure debugTree's are not "merged" for different invocations.

    @rwjblue
    rwjblue committed Sep 9, 2019
    Configuration menu
    Copy the full SHA
    2d58f11 View commit details
    Browse the repository at this point in the history

  16. Add tests for scoped addons.

    @rwjblue
    rwjblue committed Sep 9, 2019
    Configuration menu
    Copy the full SHA
    9972294 View commit details
    Browse the repository at this point in the history

  17. Only process colocated files from <app-or-addon-name>/components/

    @rwjblue
    rwjblue committed Sep 9, 2019
    Configuration menu
    Copy the full SHA
    db7e5f2 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2019

  1. Merge pull request #280 from rwjblue/colocation-refactor 

    Refactor implementation of colocation feature.
    @rwjblue
    rwjblue authored Sep 14, 2019
    Configuration menu
    Copy the full SHA
    1ef7d42 View commit details
    Browse the repository at this point in the history

  2. Fix setComponentTemplate argument ordering for native classes.

    @rwjblue
    rwjblue committed Sep 14, 2019
    Configuration menu
    Copy the full SHA
    791bde4 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2019

  1. Only opt-in to colocation when using octane edition.

    @rwjblue
    rwjblue committed Sep 15, 2019
    Configuration menu
    Copy the full SHA
    253503f View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2019

  1. Merge remote-tracking branch 'origin/master' into colocation

    @rwjblue
    rwjblue committed Sep 23, 2019
    Configuration menu
    Copy the full SHA
    35b66bf View commit details
    Browse the repository at this point in the history