Add broccoli plugin + babel plugin colocation tests #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds tests that are lower level than "build a whole app", and are intended to confirm that the colocation babel plugin works well with the colocation broccoli plugin.
5 tasks
rwjblue
commented
Oct 19, 2019
|
|
||
| // this is silly, we should use broccoli-babel-transpiler but it has **very** bad behaviors | ||
| // when used inside a process that does not end with `process.exit` (e.g. this test suite) | ||
| // See https://github.com/babel/broccoli-babel-transpiler/issues/169 for details. |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds tests that are lower level than "build a whole app", and are intended to confirm that the colocation babel plugin works well with the colocation broccoli plugin.