Allow console messages (v5.x) #740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mixonic
force-pushed
the
mixonic/allow-console-5
branch
from
f24d59d
to
d73218e
Compare
mixonic
force-pushed
the
mixonic/allow-console-5
branch
from
d73218e
to
5a0bbe5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A copy of #739 targeting a 5.x release branch.
Also fixes CI. This removes Ember 4 from CI as it fails on
LegacyPlugin cannot be invoked without 'new'. See https://github.com/ember-cli/ember-cli-htmlbars/runs/4419325026?check_suite_focus=true#step:5:146 It isn't clear if v5.x was expected to support Ember 4 or not. Based on CI, it does not, and so I've removed it from CI while leaving it in the try config.