Original Solution for Multiple Meta Modules #5582
Conversation
|
ya. lets see. @rwjblue fixed one particularly gnarly pieces of test leakage.. |
nathanhammond
force-pushed
the
original-solution
branch
3 times, most recently
from
5748c6e
to
7d30fe8
Compare
|
This one reveals a bug (I believe) in ESLint: Also, the error message is for failing to import correctly is identical. Still broken, something has to be leaking across multiple invocations of |
|
Hey @rwjblue! Want to shave years off your life? Neither @stefanpenner nor I can figure out what is going on here. If we stop testing using |
nathanhammond
force-pushed
the
original-solution
branch
4 times, most recently
from
57cd9ce
to
85dd9d3
Compare
|
☔ The latest upstream changes (presumably #5761) made this pull request unmergeable. Please resolve the merge conflicts. |
|
I suspect we should re-eval this now that @twokul identified those other issues. |
|
@nathanhammond can you rebase this on master? |
nathanhammond
force-pushed
the
original-solution
branch
from
85dd9d3
to
6d3d2d5
Compare
nathanhammond
force-pushed
the
original-solution
branch
from
fd2279e
to
6f3d5d3
Compare
|
Still fails in exactly the same way:
I don't know what to say about this test. The feature actually works, but our testing harness hates this one. @Turbo87 would you like to lose many hours of your life inspecting this one? |
|
@nathanhammond got a few other things on my todo list already 😉 |
|
☔ The latest upstream changes (presumably #5996) made this pull request unmergeable. Please resolve the merge conflicts. |
|
closing due to inactivity |
|
@Turbo87 Is there a newer PR with this feature implementation? |
|
@SergeAstapov not that I'm aware of. feel free to revive this PR if you want to take over :) |
Opening a new PR in parallel to #5233 to see if Travis is happy with the original solution. I don't want to lose the documentation in #5233 in case we haven't fixed the underlying bug.