Use ember-cli-babel to transpile vendor tree
#165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems to be working perfectly fine for us! I've tested this in a monorepo with |
buschtoens
added a commit
to buschtoens/ember-cli-addon-docs
that referenced
this pull request
Nov 19, 2018
This upgrades ember-fetch to `^6.2.0`. The primary reason for upgrading are the fixes for: - Usage of ember-fetch in monorepos: ember-cli/ember-fetch#165 https://github.com/ember-cli/ember-fetch/releases/tag/v6.1.1 - Enabling Fastboot relative URLs: ember-cli/ember-fetch#143 https://github.com/ember-cli/ember-fetch/releases/tag/v6.2.0
|
@dbouwman is out today but I can confirm that |
|
great, thanks for the feedback @mjuniper! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #156 and now also skips some transpilation steps if
config/targets.jsis configured to e.g. support native ES6 classes.Closes #163 (no longer necessary)
@dbouwman @buschtoens can you test this in your app please? 🙏
/cc @xg-wang @rwjblue