Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ember global #620

Merged
merged 3 commits into from
Jun 2, 2021
Merged

Fix ember global #620

merged 3 commits into from
Jun 2, 2021

Conversation

chancancode
Copy link
Contributor

@chancancode chancancode commented Jun 1, 2021

A minimal fix for #600. We should probably follow through with the refactor suggested by @rwjblue in #600 but that can be done later.

This is probably not very embroider friendly, but neither is the current code. It's probably easier to just rewrite the shims in terms of ES modules and embroider macros, i.e. what was suggested in #337.

@chancancode chancancode force-pushed the fix-ember-global branch 5 times, most recently from 7c6d5b6 to 45b49d8 Compare June 2, 2021 05:38
assets/browser-fetch.js.t Outdated Show resolved Hide resolved
@chancancode chancancode force-pushed the fix-ember-global branch 3 times, most recently from 6073829 to e62c0e8 Compare June 2, 2021 19:49
A minimal fix for #600. We should probably follow through with the
refactor suggested by @rwjblue in #600 but that can be done later.

This is probably not very embroider friendly, but neither is the
current code. It's probably easier to just rewrite the shims in
terms of ES modules and embroider macros, i.e. what was suggested
in #337.
@rwjblue rwjblue added the bug label Jun 2, 2021
@rwjblue rwjblue merged commit d1dba12 into master Jun 2, 2021
@rwjblue rwjblue deleted the fix-ember-global branch June 2, 2021 22:45
@izelnakri
Copy link

izelnakri commented Mar 5, 2022

Hi @chancancode ,

This is probably not very embroider friendly, but neither is the current code. It's probably easier to just rewrite the shims in terms of ES modules and embroider macros, i.e. what was suggested in #337.

I had a similar problem when upgrading this package/dependency for mber. mber does bunch of hacks to get this dependency included in the fastboot environment, now I need to adjust the hack again for <%= templates.

Despite fetch coming to newer versions of node.js, I'll probably still need this package for runloop/testing awareness and its helpers functions. So I'd really appreciate if we can rewrite these shims in terms of ES modules and macros as soon as possible instead of relying on a broccoli dependent temporary solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants