Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename import path to 'ember-fetch' #737

Closed
wants to merge 2 commits into from

Conversation

lflo5727
Copy link

@lflo5727 lflo5727 commented Oct 4, 2023

As per this issue: #330 ember-fetch is incompatible with v2 addons and still required for some Ember projects.

This fixes the issue with v2 addons and follows more direct naming conventions.
I also removed the TS portion from the README as that workaround is no longer needed now that the module name matches the import name.

@lflo5727
Copy link
Author

lflo5727 commented Oct 4, 2023

It looks like the CI tests are using too new of a version of Node for this project. They are on 18 and the project needs 14 at newest it seems

@NullVoxPopuli
Copy link
Contributor

NullVoxPopuli commented Oct 4, 2023

They are on 18 and the project needs 14 at newest it seems

would you be willing to help out with some infra updates?
I've made a to-do list here: #738

We can target the next branch so if anything needs to happen with master we aren't getting in the way

@lflo5727
Copy link
Author

lflo5727 commented Oct 4, 2023

They are on 18 and the project needs 14 at newest it seems

would you be willing to help out with some infra updates? I've made a to-do list here: #738

Anything in particular? Should we make this a v2 addon here?
Our project I'm wanting to use this for is still stuck on v3 of Ember at the moment, so not super keen on dropping support for everything < 4 in this work.

@NullVoxPopuli
Copy link
Contributor

Anything in particular? Should we make this a v2 addon here?

imo, all of it needs to be done, including v2 conversion (which is probably ~ 99% tests, and 1% actual code)

so not super keen on dropping support for everything < 4 in this work.

we'd only really be dropping IE11, I've updated #738 to call that out specifically

@lflo5727 lflo5727 closed this Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants