Skip to content
This repository has been archived by the owner on Feb 23, 2020. It is now read-only.

Linked Ember data using jQuery #66

Closed
Charizard opened this issue Mar 7, 2019 · 11 comments
Closed

Linked Ember data using jQuery #66

Charizard opened this issue Mar 7, 2019 · 11 comments

Comments

@Charizard
Copy link

Created an app using this blueprint and when trying to do a this.store.findAll('post'); it quickly hits a Cannot read property 'ajax' of undefined and noticed that the linked ember-data here is still using jQuery.

@Charizard
Copy link
Author

I realise ember-data is still in progress in making jQuery optional emberjs/data#5320. So, jQuery isn't optional after all? 🤷‍♂️

@ppcano
Copy link
Contributor

ppcano commented Mar 8, 2019

This is a known issue on the Octane Tracking issue

I think emberjs/data#5386 will solve it.

@Charizard
Copy link
Author

@ppcano Makes sense. Thanks!!

@NullVoxPopuli
Copy link
Collaborator

Well, this is still an issue. I'm hoping this lights some fire under the butts of ember-data. :)
(Though, after emberconf, I'll have time to help out those efforts)

@Charizard
Copy link
Author

@NullVoxPopuli Then, do you want this to be re-opened so the fire burns brightly 😛 ?

@NullVoxPopuli
Copy link
Collaborator

yes :)
Also, I rebased: emberjs/data#5900

@NullVoxPopuli NullVoxPopuli reopened this Mar 8, 2019
@rwjblue
Copy link
Member

rwjblue commented Mar 8, 2019

While we wait for progress there, we should add ember-fetch and setup its ember-data integration to avoid issues without jQuery.

@NullVoxPopuli
Copy link
Collaborator

probably. anything to reduce friction is good, imo

@Charizard
Copy link
Author

Charizard commented Mar 13, 2019

@rwjblue @NullVoxPopuli Yes, that should be helpful. I did NOT know about ember-fetch's ember-data integration until I brought this up in Twitter.

@rwjblue
Copy link
Member

rwjblue commented Mar 13, 2019

FWIW, ember-data's master branch just merged a PR that should allow usage without jQuery and without special customization of the application adapter (which is what the ember-fetch mixin does).

See emberjs/data#5900

@NullVoxPopuli
Copy link
Collaborator

closed by: #77

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants