-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Octane Tracking Issue #17234
Comments
@MelSumner We should track the build pipeline improvements in https://github.com/embroider-build/embroider as well. |
@MelSumner https://broccoli.build and https://github.com/broccolijs/broccolijs.github.io for the new broccoli site and docs |
Tracked properties RFC can be checked off and link updated. |
We talked about auditing what gets included in the default app blueprint. See related issues: |
FWIW, @tomdale that seems quite orthogonal to the Octane Edition to me (not saying we shouldn't be more careful and have better checks/balances, just that its not related to octane at all)... |
My reasoning for bringing this up recently is that a default blueprint that supports multiple programming models (i.e., a future default octane blueprint) may include extra cruft that a pure "classic" app or pure "octane" app doesn't need at all. If we can validate that this is not a concern, I agree that this isn't very closely related to octane |
imo, the octane blueprint, https://github.com/ember-cli/ember-octane-blueprint should be the ideal brand new / shiny app. I don't think the old programming model should be involved in the blueprint. :-\ |
@MelSumner - I think we need to get some MU related things here in this checklist (I don't spot any, but AFAICT MU is still considered part of the octane feature set...). |
It's already been called Octane layout instead of MU layout ... and the more I think about it the more it makes sense! |
@rwjblue we linked to the MU quest issue in the first section- "Finish What We Started" - is there more that you think we should track? |
Regarding Personally, I wouldn't see Let me know, if that would make a good addition or better postpone it to post-octane release or how I can help with that. |
octane blueprint > move addon to ember-cli org can be checked off :) |
Update, here's a quest issue for tracking the Angle Brackets conversion in the guides ember-learn/guides-source#139 |
The Remove jQuery RFC can be checked off! ✅ |
User story around feature flags and optional features, as it pertains to the octane blueprint
|
FYI - I just published @ember/render-modifiers 1.0.0 with support back to Ember 2.12 (by way of ember-modifier-manager-polyfill). There is still a bit of work to do (need tons more documentation), but its a good start... |
@MelSumner I will work on the Native JS Classes blueprints. |
Has anyone put thought into what should happen for https://github.com/ember-cli/ember-new-output in the Classic+Octane world? |
The output in that repo will match the output of |
It looks like module unification is missing from the "Practical Implementation of Roadmap RFC" section. |
I believe that Template Imports are the major piece that hasn't shipped yet, so that's the bit that we're tracking in this issue. Does that help, @michaelrkn ? |
@MelSumner Got it, thanks! |
Hey everybody, the implementation of the "Remove jQuery" RFC is mostly done (at least as far as the first Ember 3.x stage is concerned, see #17476). What's still open and blocking the (default, non-octane) blueprints to switch to no jQuery by default is the built-in ability of ember-data to work with Just to let you know... maybe this should be addressed at one of the next core team meetings, to help bring this over the finish line? |
a couple things related to ember-cli that I would like to be added to the list:
moduleConfig.collections = Object.assign(moduleConfig.collections, {
// ember-simple-auth
authenticators: {
types: ['authenticator'],
defaultType: 'authenticator'
}
}); (the above, courtesy of @sly7-7 :D ) moduleConfig.types = Object.assign(moduleConfig.types, {
// ember-intl
'ember-intl@adapter': { definitiveCollection: 'main' },
'ember-intl@translation': { definitiveCollection: 'main' },
translation: { definitiveCollection: 'main' },
formats: { definitiveCollection: 'main' },
cldr: { definitiveCollection: 'main' },
'util:intl': { definitiveCollection: 'utils' },
'intl:util': { definitiveCollection: 'utils' },
// ember-gestures
'ember-gesture': { definitiveCollection: 'main' },
}); and then the other thing also related to ember-cli is supporting multiple dummy apps.
Also, not sure how to track this, but with @miguelcobain 's ember-paper library, I'd like to coordinate with getting the octane setup process super simple (currently it's not simple to use ember-paper in octane apps)
seems like it mostly has to do with there styles get exposed to the host app. idk if there is something simple we can do so that existing style addons can "just work", or if we're going to make all the style addons add an octane / isModuleUnification condition? |
|
|
@MelSumner Yup, brought this up at the ED meeting, we are gonna follow up and refactor the ember-fetch PR emberjs/data#5386 |
|
@tomdale, @MelSumner, @rwjblue Template Imports ( Working Draft ) |
FYI, the Component Templates Co-locations RFC is not on this tracking issue yet. :) |
@Panman8201 correct- it's outside of the scope for Octane. :) |
I think this need to bee updated with ember octane 3.15+ release :) |
Since we've shipped Octane, going to close this issue. |
Summary
The purpose of this issue is to provide an overall issue to track the status of the work necessary to ship the Octane Edition of Ember.js.
If anyone wants to work on any of the items in this list, please check in the #st-octane channel of our Discord chat first.
The following to-do list will be updated to include links to individual issues as they are created. The issues themselves will contain more details for each item on this list.
Goals from Roadmap RFC
Finish What We Started (Part 1 of 2)
As per the 2018 Roadmap RFC, there is commitment and focus to finishing the things we've already started.
Module Unification [Tracking Issue]- De-scoped from this edition as per https://blog.emberjs.com/2019/03/11/update-on-module-unification-and-octane.htmlNative JavaScript modules- De-scoped from this editionOctane Edition Features (Part 2 of 2)
As per the roadmap RFC, these are the goals for the Octane edition; however it should be noted that
"the final timeline and feature set of Ember Octane will be determined by the core teams and are not set in stone in this RFC."
Svelte Builds(moved to next edition)Incremental rendering and rehydration(moved to next edition)Treeshaking(moved to next edition)Stabilizing Ember Data(moved to next edition)Practical Implementation of Roadmap RFC
Decorators
Core Team Champion: Tom Dale | Status: completed 🎉
Glimmer Components (as the default component API)
Core Team Champion: Tom Dale | Status: completed 🎉
Tracked Properties
Core Team Champion: Tom Dale | Status: completed 🎉
Element Modifiers
Core Team Champion: Tom Dale | Status: completed 🎉
Editions
Core Team Champion: @tomdale | Status: on track ✅
Remove jQuery by Default
Core Team Champion: Robert Jackson (@rwjblue) | Status: completed 🎉
Native JS Classes
Core Team Champion: Robert Jackson | Status: completed 🎉
Broccoli 2.0
Core Team Champion: Robert Jackson (@rwjblue) | Status: on track ✅
Ember Guides Updates
Core Team Champion: Jen Weber (@jenweber) | Status: on track ✅
Website Re-design
Core Team Champion: Leah Silber (@wifelette) & Mel Sumner (@MelSumner) | Status: delayed
Scope Creep
These are new items that we discovered were necessary to add while implementing Octane features.
on
modifierCore Team Champion: Robert Jackson (@rwjblue) | Status: completed 🎉
{{on}}
Modifier rfcs#471 [tracking issue]fn
helperCore Team Champion: Robert Jackson (@rwjblue) | Status: completed 🎉
{{fn}}
Helper rfcs#470 [tracking issue]Injection Parameter Normalization (owner tunnel/class portal)
Core Team Champion: Robert Jackson (@rwjblue) | Status: completed 🎉
@classic
decoratorCore Team Champion: Robert Jackson (@rwjblue) | Status: on track
@classic
Decorator rfcs#468Ember Inspector
[Tracking Issue]
Supporting TODOs
Stretch Goals/De-scoped items
These are items that were de-scoped from Octane and are now being tracked as stretch goals.
Project Management
Details
Upgrading Apps to Octane
Required
Dependencies
ember-source@3.??.0
ember-data@3.??.0
Optional Features
application-template-wrapper
tofalse
jquery-integration
tofalse
template-only-glimmer-components
totrue
.ember-cli
ember generate component
to include (per RFC #481):--no-component-class
--component-structure=flat
Optional / Incremental
EmberObject.extend()
to native classesFinal Checklist
The text was updated successfully, but these errors were encountered: