Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements for blueprint index.html title removal #179

Merged
merged 3 commits into from
Sep 24, 2020
Merged

Improvements for blueprint index.html title removal #179

merged 3 commits into from
Sep 24, 2020

Conversation

raido
Copy link
Contributor

@raido raido commented Sep 24, 2020 •
edited
Loading

Few improvements:

  • use project.isEmberCLIAddon() for detecting host app
  • avoid crashing if title is not present in the first place.
  • support for multiline <title> element

This is a follow up for #174.

@raido raido changed the title chore: Use project.isEmberCLIAddon() instead Improvements for blueprint index.html title removal Sep 24, 2020
@raido raido mentioned this pull request Sep 24, 2020
Open
knownasilya
knownasilya approved these changes Sep 24, 2020
View reviewed changes
Copy link
Contributor

@knownasilya knownasilya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🙂

@knownasilya knownasilya merged commit 6fdf2b2 into ember-cli:master Sep 24, 2020
@raido raido deleted the update-addon-detection-in-blueprint branch September 24, 2020 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knownasilya knownasilya knownasilya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raido @knownasilya