Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline used @ember/string methods directly #932

Closed
lifeart opened this issue Jul 13, 2023 · 1 comment · Fixed by #933
Closed

Inline used @ember/string methods directly #932

lifeart opened this issue Jul 13, 2023 · 1 comment · Fixed by #933

Comments

@lifeart
Copy link
Contributor

lifeart commented Jul 13, 2023

After ember@5 - ember-resolver is only one "bundled" dependency with @ember/string.

This ticket is created to follow on @ember/string deprecation.

We need to inline @ember/string methods here (used in resolver).

https://github.com/emberjs/ember-string/blob/master/addon/index.ts

https://github.com/ember-cli/ember-resolver/blob/main/addon/addon/index.js#L6

@lifeart
Copy link
Contributor Author

lifeart commented Jul 13, 2023

In addition, it seems very valid to have infinity cache (https://github.com/emberjs/ember-string/blob/master/addon/cache.ts) here for resolver (because amount of items is finite) to not trigger gc in large ember applications during loading/components rendering.

upd: it's better to move @ember/string as is (for now)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant