Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate @ember/string usage. #8711

Closed
lifeart opened this issue Jul 13, 2023 · 1 comment
Closed

Deprecate @ember/string usage. #8711

lifeart opened this issue Jul 13, 2023 · 1 comment
Labels

Comments

@lifeart
Copy link

lifeart commented Jul 13, 2023

Since ember-source does not rely on @ember/string anymore.

We found usages of @ember/string in
@ember-data/adapter, @ember-data/debug, @ember-data/model, @ember-data/serializer,
@ember-data/store, ember-data deps.

Code search: https://github.com/search?q=repo%3Aemberjs%2Fdata%20%22%40ember%2Fstring%22&type=code

It seems we could try to replace/omit it and completely deprecate @ember/string.

Related stuff: ember-cli/ember-resolver#932, ember-cli/ember-resolver#933

@runspired
Copy link
Contributor

We do not use ember-source for it, we declare the peer-dependency.

There isn't a good library out there that replaces it (or ember-inflector) I've investigated that a few times. I've been considering having EmberData ship its own string utils since long-term we only need camelize for the REST url builder, underscore for the ActiveRecord url builder, and pluralize for all builders. All other string functions i think end up unused except potentially for debug assertions once the deprecation for type-matches-registry-name is complete.

Closing since this work is already tracked in #8460 and #8147 and the RFC for strict types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants