Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit support for Ember 4.12 and 5.x #190

Merged
merged 3 commits into from
Aug 16, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 17 additions & 14 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v1
- uses: actions/setup-node@v1
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 16.x
- name: install dependencies
Expand All @@ -35,8 +35,8 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v1
- uses: actions/setup-node@v1
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 16.x
- name: install dependencies
Expand All @@ -62,8 +62,8 @@ jobs:
node-version: [16.x, 18.x]

steps:
- uses: actions/checkout@v1
- uses: actions/setup-node@v1
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
- name: install dependencies
Expand All @@ -88,8 +88,8 @@ jobs:
os: [macos, windows]

steps:
- uses: actions/checkout@v1
- uses: actions/setup-node@v1
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 16.x
- name: install dependencies
Expand All @@ -110,8 +110,8 @@ jobs:
needs: [test, lint]

steps:
- uses: actions/checkout@v1
- uses: actions/setup-node@v1
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 16.x
- name: install dependencies
Expand All @@ -135,15 +135,18 @@ jobs:
matrix:
ember-try-scenario:
- ember-3.27
- ember-4.12
- ember-release
- ember-beta
- ember-canary
- embroider-safe
- embroider-optimized
- embroider-safe-min-supported
- embroider-optimized-min-supported
- embroider-safe-release
- embroider-optimized-release

steps:
- uses: actions/checkout@v1
- uses: actions/setup-node@v1
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 16.x
- name: install dependencies
Expand Down
63 changes: 60 additions & 3 deletions config/ember-try.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,18 @@ const getChannelURL = require('ember-source-channel-url');
const { embroiderSafe, embroiderOptimized } = require('@embroider/test-setup');

module.exports = async function () {
const ember5Deps = {
'@ember/string': '^3.1.1',
'@ember/test-helpers': '^3.2.0',
'ember-qunit': '^7.0.0',
'ember-resolver': '^11.0.0',
'ember-auto-import': '^2.3.0',
'ember-cli': '^5.1.0',
'ember-maybe-import-regenerator': null,
};

const release = await getChannelURL('release');

return {
useYarn: true,
scenarios: [
Expand All @@ -15,11 +27,20 @@ module.exports = async function () {
},
},
},
{
name: 'ember-4.12',
npm: {
devDependencies: {
'ember-source': '~4.12.3',
},
},
},
{
name: 'ember-release',
npm: {
devDependencies: {
'ember-source': await getChannelURL('release'),
'ember-source': release,
...ember5Deps,
},
},
},
Expand All @@ -28,6 +49,8 @@ module.exports = async function () {
npm: {
devDependencies: {
'ember-source': await getChannelURL('beta'),
'ember-cli': '^5.0.0',
...ember5Deps,
},
},
},
Expand All @@ -36,11 +59,45 @@ module.exports = async function () {
npm: {
devDependencies: {
'ember-source': await getChannelURL('canary'),
'ember-cli': '^5.0.0',
...ember5Deps,
},
},
},
embroiderSafe(),
embroiderOptimized(),
embroiderSafe({
name: 'embroider-safe-min-supported',
npm: {
devDependencies: {
'ember-source': '~3.27.0',
},
},
}),
embroiderOptimized({
name: 'embroider-optimized-min-supported',
npm: {
devDependencies: {
'ember-source': '~3.27.0',
},
},
}),
embroiderSafe({
name: 'embroider-safe-release',
npm: {
devDependencies: {
'ember-source': release,
...ember5Deps,
},
},
}),
embroiderOptimized({
name: 'embroider-optimized-release',
npm: {
devDependencies: {
'ember-source': release,
...ember5Deps,
},
},
}),
],
};
};