Do not require parent addon to include ember-cli-htmlbars #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ontain ember-cli-htmlbars
rwjblue
reviewed
Oct 25, 2022
rwjblue
reviewed
Oct 25, 2022
Comment on lines
+26
to
+29
| // Used in ember-cli-htmlbars to get the location of templateCompiler without traversing this.addons (https://github.com/ember-cli/ember-cli-htmlbars/blob/6860beed9a357d5e948abd09754e8a978fed1320/lib/ember-addon-main.js#L264) | ||
| let ember = this.project.findAddonByName('ember-source'); | ||
|
|
||
| this.templateCompilerPath = ember.absolutePaths.templateCompiler; |
There was a problem hiding this comment.
Quick note here: this is public API from Ember's perspective for determining the path to the template compiler. Basically:
const emberAddon = require('ember-source');
const templateCompiler = require(emberAddon.absolutePaths.templateCompiler);
rwjblue
reviewed
Oct 25, 2022
rwjblue
approved these changes
Oct 25, 2022
rwjblue
changed the title
|
I think this means we should also remove the peerDependency on ember-cli-htmlbars, yes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When adding
ember-template-importsto my addon to parse template imports it required a hard dependency on ember-cli-htmlbars which resulted in the following error if I didn't add it to my project.With this change it will use the templateCompiler provided by ember-source which passes tests and doesn't require me to add a hard dependency on ember-cli-htmlbars.