Skip to content

Commit

Permalink
Added a test case to show the regression
Browse files Browse the repository at this point in the history
  • Loading branch information
Larry Yu committed Feb 8, 2023
1 parent aa4d1ba commit 2d14d9d
Show file tree
Hide file tree
Showing 2 changed files with 26 additions and 0 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,8 @@ jobs:
# Environment variables from config
- ./node_modules/.bin/ember try:each --config-path='../test/fixtures/dummy-ember-try-config-different-env-vars.js'

# fs-extra versions 7.x and above caused a regresion
- ./node_modules/.bin/ember try:each --config-path='../test/fixtures/dummy-ember-try-config-fs-extra-scenarios.js'

steps:
- uses: actions/checkout@v1
Expand Down
24 changes: 24 additions & 0 deletions test/fixtures/dummy-ember-try-config-fs-extra-scenarios.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
module.exports = {
scenarios: [
{
name: 'Ember try should succeed when using fs-extra version 6.x',
npm: {
devDependencies: {
'watchpack-chokidar2': '2.0.1',
'ember-try-test-suite-helper': '1.0.0',
'fs-extra': '6.0.1',
},
},
},
{
name: 'Ember try should fail when using fs-extra version 9.x',
npm: {
devDependencies: {
'watchpack-chokidar2': '2.0.1',
'ember-try-test-suite-helper': '1.0.0',
'fs-extra': '9.0.1',
},
},
},
],
};

0 comments on commit 2d14d9d

Please sign in to comment.