Quick bug fix for confirm unload firing on Chrome too often

ember-cli · Mar 24, 2016 · fd028a7 · fd028a7
1 parent 20e7b09
commit fd028a7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/app/gist/route.js b/app/gist/route.js
@@ -30,12 +30,12 @@ export default Ember.Route.extend({
   },
 
   confirmUnload(event) {
-    if (this.get('controller.unsaved')) {
+    if (this.get('controller.unsaved') === true) {
       if (!window.confirm(CONFIRM_MSG)) {
         event.preventDefault();
       }
+      return CONFIRM_MSG; // for Chrome
     }
-    return CONFIRM_MSG; // for Chrome
   },
 
   actions: {

diff --git a/app/routes/gist-base-route.js b/app/routes/gist-base-route.js
@@ -22,7 +22,7 @@ export default Ember.Route.extend({
   actions: {
     willTransition(transition) {
       const gistController = this.controllerFor('gist');
-      if (gistController.get('unsaved')) {
+      if (gistController.get('unsaved') === true) {
         if (!window.confirm(CONFIRM_MSG)) {
           transition.abort();
         }