Fix #557: Adds extra menu item for renaming a file #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. Would you mind adding a quick test to https://github.com/ember-cli/ember-twiddle/blob/master/tests/integration/components/file-menu-test.js ? |
Gaurav0
approved these changes
Feb 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've deicded to solve this issue by adding an extra menu item instead of writing something like "Move / Rename {{filename}}" or "Move or rename {{filename}} since I think it creates a lot of clutter. This won't help users figure out how to rename.
Instead rename and move are seperate items of the menu with the same functionality. In my oppinion this provides a better user experience and more clearity.