Fix didResize method undefined bug in canary #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gaurav0
force-pushed
the
fix_didResize_bug
branch
from
b3ae102
to
1b68bad
Compare
knownasilya
approved these changes
May 11, 2018
knownasilya
pushed a commit
to knownasilya/ember-twiddle
that referenced
this pull request
Jul 3, 2018
* Update ember-cli-uglify * Update some dependencies * Update more dependencies * Update yet more dependencies * Upgrade ember-cli to 2.13 * Upgrade ember-data to 2.13 * Upgrade ember-data to 2.18 * Try to fix travis failure * Upgrade to ember-cli-qunit@4 * Upgrade ember-cli-mirage * Upgrade ember-cli to 2.14 * Upgrade ember-cli to 2.15 * Added info about where the backend is * Fix didResize method undefined bug in canary (ember-cli#613) * Support New module imports * Changes after making ember-cli-cjs-transform configurable * Update ember-cli-cjs-transform * Support Ember 2.17 and 2.18 * Fix ability to sign in via github * v0.14.1 * yarn upgrade * Deprecate old versions of Ember * Support Ember 3.0 - 3.2 * updates contribution guide (ember-cli#621) * Try to upgrade ember-cli-qunit to 4.3.x * Fixed the damn ember-cli-qunit build * cleanup * Fix tests for tests * Refactor and reorganize ember-cli-build.js * Migrate to using babel-preset-env. (ember-cli#627) * Drop transpilation for IE. `last 2 versions` will target IE10 and IE11, which we don't support... * Migrate to using babel-preset-env. This will lead to less transpilation (e.g. we can use native async/await now, instead of transpiling). * Adds keyboard shortcut option to comment javascript code. (ember-cli#622) * adds shortcut comment option for javascript code * Adds test * change from `keypress` to `keydown` to trigger events * comment logic moved to initializer * fix test server shutdown * adds keyboard shortcuts for `run now` and `save` (ember-cli#628) * adds keyboard shortcuts for `run now` and `save` * adds deps for unit test * using e-keyboard test helper * minor tweaks * Bump Ember Data * Fix dependency test was timing out again
knownasilya
pushed a commit
to knownasilya/ember-twiddle
that referenced
this pull request
Jul 3, 2018
* Update ember-cli-uglify * Update some dependencies * Update more dependencies * Update yet more dependencies * Upgrade ember-cli to 2.13 * Upgrade ember-data to 2.13 * Upgrade ember-data to 2.18 * Try to fix travis failure * Upgrade to ember-cli-qunit@4 * Upgrade ember-cli-mirage * Upgrade ember-cli to 2.14 * Upgrade ember-cli to 2.15 * Added info about where the backend is * Fix didResize method undefined bug in canary (ember-cli#613) * Support New module imports * Changes after making ember-cli-cjs-transform configurable * Update ember-cli-cjs-transform * Support Ember 2.17 and 2.18 * Fix ability to sign in via github * v0.14.1 * yarn upgrade * Deprecate old versions of Ember * Support Ember 3.0 - 3.2 * updates contribution guide (ember-cli#621) * Try to upgrade ember-cli-qunit to 4.3.x * Fixed the damn ember-cli-qunit build * cleanup * Fix tests for tests * Refactor and reorganize ember-cli-build.js * Migrate to using babel-preset-env. (ember-cli#627) * Drop transpilation for IE. `last 2 versions` will target IE10 and IE11, which we don't support... * Migrate to using babel-preset-env. This will lead to less transpilation (e.g. we can use native async/await now, instead of transpiling). * Adds keyboard shortcut option to comment javascript code. (ember-cli#622) * adds shortcut comment option for javascript code * Adds test * change from `keypress` to `keydown` to trigger events * comment logic moved to initializer * fix test server shutdown * adds keyboard shortcuts for `run now` and `save` (ember-cli#628) * adds keyboard shortcuts for `run now` and `save` * adds deps for unit test * using e-keyboard test helper * minor tweaks * Bump Ember Data * Fix dependency test was timing out again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this bug was introduced with ESLint fixes.