Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Ember 3.0 - 3.2 #619

Merged
merged 2 commits into from
Jun 9, 2018
Merged

Support Ember 3.0 - 3.2 #619

merged 2 commits into from
Jun 9, 2018

Conversation

Gaurav0
Copy link
Contributor

@Gaurav0 Gaurav0 commented Jun 8, 2018 •
edited
Loading

Also deprecates:

  1. Bringing in ember-data as a dependency rather than an addon
  2. Ember versions prior to 2.12

Fixes #609

@Gaurav0 Gaurav0 requested a review from a team June 8, 2018 19:20
rwjblue
rwjblue reviewed Jun 8, 2018
View reviewed changes
app/services/dependency-resolver.js
library: 'ember.js',
fileName: 'ember.debug.js'
},

'ember-template-compiler': {
pakage: 'ember-source',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo here, should be package

Copy link
Contributor Author

@Gaurav0 Gaurav0 Jun 8, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, package turned out to be a reserved word. So I misspelled it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ha! kk

@Gaurav0 Gaurav0 merged commit 34492fe into ember-cli:master Jun 9, 2018
@Gaurav0 Gaurav0 deleted the jsdelivr branch June 9, 2018 11:59
@sdhull
Copy link

sdhull commented Jun 29, 2018

Has this been deployed? I copied the blueprint for twiddle.json out of this PR and into the site and it doesn't work 😢

Same deal as before, GET https://cdnjs.cloudflare.com/ajax/libs/ember.js/3.2.0/ember.debug.js 404

@Gaurav0
Copy link
Contributor Author

Gaurav0 commented Jun 29, 2018 •
edited
Loading

@sdhull It has been deployed to https://canary.ember-twiddle.com

@sdhull
Copy link

sdhull commented Jun 29, 2018

Ohhhh thanks @Gaurav0!!! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gaurav0 @sdhull @rwjblue