Merge pull request #1237 from bmish/deprecated-report-api

ember-cli · Jun 14, 2021 · 48a5d33 · 48a5d33
2 parents 6559ca5 + 473a816
commit 48a5d33
Show file tree

Hide file tree

Showing 42 changed files with 88 additions and 65 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -97,7 +97,6 @@ module.exports = {
 
     // eslint-plugin rules:
     'eslint-plugin/consistent-output': ['error', 'always'],
-    'eslint-plugin/no-deprecated-report-api': 'off',
     'eslint-plugin/require-meta-docs-url': [
       'error',
       {

diff --git a/lib/rules/alias-model-in-controller.js b/lib/rules/alias-model-in-controller.js
@@ -24,7 +24,7 @@ module.exports = {
     const message = 'Alias your model';
 
     const report = function (node) {
-      context.report(node, message);
+      context.report({ node, message });
     };
 
     const sourceCode = context.getSourceCode();

diff --git a/lib/rules/avoid-leaking-state-in-ember-objects.js b/lib/rules/avoid-leaking-state-in-ember-objects.js
@@ -76,7 +76,7 @@ module.exports = {
     const report = function (node) {
       const message =
         'Only string, number, symbol, boolean, null, undefined, and function are allowed as default properties';
-      context.report(node, message);
+      context.report({ node, message });
     };
 
     const sourceCode = context.getSourceCode();

diff --git a/lib/rules/avoid-using-needs-in-controllers.js b/lib/rules/avoid-using-needs-in-controllers.js
@@ -23,7 +23,7 @@ module.exports = {
     const report = function (node) {
       const message =
         '`needs` API has been deprecated, `Ember.inject.controller` should be used instead';
-      context.report(node, message);
+      context.report({ node, message });
     };
 
     const sourceCode = context.getSourceCode();

diff --git a/lib/rules/closure-actions.js b/lib/rules/closure-actions.js
@@ -25,7 +25,7 @@ module.exports = {
 
   create(context) {
     const report = function (node) {
-      context.report(node, ERROR_MESSAGE);
+      context.report({ node, message: ERROR_MESSAGE });
     };
 
     return {

diff --git a/lib/rules/computed-property-getters.js b/lib/rules/computed-property-getters.js
@@ -38,7 +38,7 @@ module.exports = {
     const requireGetters = context.options[0] || 'always-with-setter';
 
     const report = function (node, message) {
-      context.report(node, message);
+      context.report({ node, message });
     };
 
     const requireGetterOnlyWithASetterInComputedProperty = function (node) {

diff --git a/lib/rules/jquery-ember-run.js b/lib/rules/jquery-ember-run.js
@@ -46,7 +46,7 @@ module.exports = {
 
   create(context) {
     const report = function (node) {
-      context.report(node, ERROR_MESSAGE);
+      context.report({ node, message: ERROR_MESSAGE });
     };
 
     let importedEmberName;

diff --git a/lib/rules/named-functions-in-promises.js b/lib/rules/named-functions-in-promises.js
@@ -37,7 +37,7 @@ module.exports = {
     const message = 'Use named functions defined on objects to handle promises';
 
     const report = function (node) {
-      context.report(node, message);
+      context.report({ node, message });
     };
 
     return {

diff --git a/lib/rules/new-module-imports.js b/lib/rules/new-module-imports.js
@@ -48,7 +48,7 @@ module.exports = {
             type: item.type,
           });
 
-          context.report(item, message);
+          context.report({ node: item, message });
         }
       }
     }
@@ -83,7 +83,7 @@ module.exports = {
                 type: item.type,
               });
 
-              context.report(item, message);
+              context.report({ node: item, message });
             }
           }
         }
@@ -111,7 +111,7 @@ module.exports = {
           // JS module import for it, so do not report the error
           if (match) {
             const message = buildMessage({ node, fullName, key, match });
-            context.report(node, message);
+            context.report({ node, message });
             break;
           }
         }

diff --git a/lib/rules/no-actions-hash.js b/lib/rules/no-actions-hash.js
@@ -24,7 +24,7 @@ module.exports = {
     function reportActionsProp(properties) {
       const actionsProp = properties.find((property) => ember.isActionsProp(property));
       if (actionsProp) {
-        context.report(actionsProp, ERROR_MESSAGE);
+        context.report({ node: actionsProp, message: ERROR_MESSAGE });
       }
     }
 

diff --git a/lib/rules/no-arrow-function-computed-properties.js b/lib/rules/no-arrow-function-computed-properties.js
@@ -71,10 +71,16 @@ module.exports = {
 
         if (onlyThisContexts) {
           if (isThisPresent) {
-            context.report(node.arguments[node.arguments.length - 1], ERROR_MESSAGE);
+            context.report({
+              node: node.arguments[node.arguments.length - 1],
+              message: ERROR_MESSAGE,
+            });
           }
         } else {
-          context.report(node.arguments[node.arguments.length - 1], ERROR_MESSAGE);
+          context.report({
+            node: node.arguments[node.arguments.length - 1],
+            message: ERROR_MESSAGE,
+          });
         }
       },
     };

diff --git a/lib/rules/no-attrs-in-components.js b/lib/rules/no-attrs-in-components.js
@@ -54,7 +54,7 @@ module.exports = {
 
       MemberExpression(node) {
         if (currentEmberComponent && isThisAttrsExpression(node)) {
-          context.report(node.property, ERROR_MESSAGE);
+          context.report({ node: node.property, message: ERROR_MESSAGE });
         }
       },
     };

diff --git a/lib/rules/no-attrs-snapshot.js b/lib/rules/no-attrs-snapshot.js
@@ -35,7 +35,7 @@ module.exports = {
 
   create(context) {
     const report = function (node) {
-      context.report(node, ERROR_MESSAGE);
+      context.report({ node, message: ERROR_MESSAGE });
     };
 
     return {

diff --git a/lib/rules/no-classic-classes.js b/lib/rules/no-classic-classes.js
@@ -72,7 +72,7 @@ module.exports = {
     const additionalClassImports = options.additionalClassImports || [];
 
     function reportNode(node) {
-      context.report(node, ERROR_MESSAGE_NO_CLASSIC_CLASSES);
+      context.report({ node, message: ERROR_MESSAGE_NO_CLASSIC_CLASSES });
     }
 
     return {

diff --git a/lib/rules/no-classic-components.js b/lib/rules/no-classic-components.js
@@ -23,7 +23,7 @@ module.exports = {
 
   create(context) {
     const report = function (node) {
-      context.report(node, ERROR_MESSAGE);
+      context.report({ node, message: ERROR_MESSAGE });
     };
 
     return {

diff --git a/lib/rules/no-computed-properties-in-native-classes.js b/lib/rules/no-computed-properties-in-native-classes.js
@@ -55,7 +55,7 @@ module.exports = {
     let computedNodes = [];
 
     const report = function (node) {
-      context.report(node, ERROR_MESSAGE);
+      context.report({ node, message: ERROR_MESSAGE });
     };
 
     return {

diff --git a/lib/rules/no-controller-access-in-routes.js b/lib/rules/no-controller-access-in-routes.js
@@ -77,7 +77,7 @@ module.exports = {
           node.property.name === 'controller'
         ) {
           // Example: this.controller;
-          context.report(node, ERROR_MESSAGE);
+          context.report({ node, message: ERROR_MESSAGE });
         }
       },
 
@@ -99,7 +99,7 @@ module.exports = {
           node.callee.property.name === 'controllerFor'
         ) {
           // Example this.controllerFor(...);
-          context.report(node, ERROR_MESSAGE);
+          context.report({ node, message: ERROR_MESSAGE });
         }
 
         if (
@@ -112,7 +112,7 @@ module.exports = {
           node.arguments[0].value === 'controller'
         ) {
           // Example: this.get('controller');
-          context.report(node, ERROR_MESSAGE);
+          context.report({ node, message: ERROR_MESSAGE });
         }
 
         if (
@@ -124,7 +124,7 @@ module.exports = {
           node.arguments[1].value === 'controller'
         ) {
           // Example: get(this, 'controller');
-          context.report(node, ERROR_MESSAGE);
+          context.report({ node, message: ERROR_MESSAGE });
         }
 
         if (
@@ -135,7 +135,7 @@ module.exports = {
           getPropertiesArgumentsIncludeController(node.arguments)
         ) {
           // Example: this.getProperties('controller');
-          context.report(node, ERROR_MESSAGE);
+          context.report({ node, message: ERROR_MESSAGE });
         }
 
         if (
@@ -145,7 +145,7 @@ module.exports = {
           getPropertiesArgumentsIncludeController(node.arguments.slice(1))
         ) {
           // Example: getProperties(this, 'controller');
-          context.report(node, ERROR_MESSAGE);
+          context.report({ node, message: ERROR_MESSAGE });
         }
       },
 

diff --git a/lib/rules/no-controllers.js b/lib/rules/no-controllers.js
@@ -29,7 +29,7 @@ module.exports = {
           ember.isEmberController(context, node) &&
           (node.body.body.length === 0 || !classDeclarationHasProperty(node, 'queryParams'))
         ) {
-          context.report(node, ERROR_MESSAGE);
+          context.report({ node, message: ERROR_MESSAGE });
         }
       },
 
@@ -39,7 +39,7 @@ module.exports = {
           (node.arguments.length === 0 ||
             !callExpressionClassHasProperty(node, 'queryParams', scopeManager))
         ) {
-          context.report(node, ERROR_MESSAGE);
+          context.report({ node, message: ERROR_MESSAGE });
         }
       },
     };

diff --git a/lib/rules/no-current-route-name.js b/lib/rules/no-current-route-name.js
@@ -35,7 +35,7 @@ module.exports = {
       CallExpression(node) {
         const { callee } = node;
         if (callee.type === 'Identifier' && importAliases.includes(callee.name)) {
-          context.report(node, ERROR_MESSAGE);
+          context.report({ node, message: ERROR_MESSAGE });
         }
       },
     };

diff --git a/lib/rules/no-ember-testing-in-module-scope.js b/lib/rules/no-ember-testing-in-module-scope.js
@@ -45,14 +45,14 @@ module.exports = {
           node.parent.object.name === emberImportAliasName
         ) {
           if (context.getScope().variableScope.type === 'module') {
-            context.report(node.parent, ERROR_MESSAGES[0]);
+            context.report({ node: node.parent, message: ERROR_MESSAGES[0] });
           }
           const nodeGrandParent = utils.getPropertyValue(node, 'parent.parent.type');
           if (
             nodeGrandParent === 'AssignmentExpression' ||
             nodeGrandParent === 'VariableDeclarator'
           ) {
-            context.report(node.parent.parent, ERROR_MESSAGES[1]);
+            context.report({ node: node.parent.parent, message: ERROR_MESSAGES[1] });
           }
         }
       },
@@ -66,7 +66,7 @@ module.exports = {
               ancestorNode.init.name === emberImportAliasName
           )
         ) {
-          context.report(node.parent.parent.parent, ERROR_MESSAGES[2]);
+          context.report({ node: node.parent.parent.parent, message: ERROR_MESSAGES[2] });
         }
       },
     };

diff --git a/lib/rules/no-empty-attrs.js b/lib/rules/no-empty-attrs.js
@@ -24,7 +24,7 @@ module.exports = {
     const filePath = context.getFilename();
 
     const report = function (node) {
-      context.report(node, message);
+      context.report({ node, message });
     };
 
     const sourceCode = context.getSourceCode();

diff --git a/lib/rules/no-empty-glimmer-component-classes.js b/lib/rules/no-empty-glimmer-component-classes.js
@@ -27,7 +27,7 @@ module.exports = {
     return {
       ClassDeclaration(node) {
         if (isGlimmerComponent(context, node) && node.body.body.length === 0) {
-          context.report(node, ERROR_MESSAGE);
+          context.report({ node, message: ERROR_MESSAGE });
         }
       },
     };

diff --git a/lib/rules/no-function-prototype-extensions.js b/lib/rules/no-function-prototype-extensions.js
@@ -34,7 +34,7 @@ module.exports = {
     };
 
     const report = function (node) {
-      context.report(node, message);
+      context.report({ node, message });
     };
 
     return {

diff --git a/lib/rules/no-get.js b/lib/rules/no-get.js
@@ -264,7 +264,7 @@ module.exports = {
           validateGetPropertiesArguments(node.arguments, ignoreNestedPaths)
         ) {
           // Example: this.getProperties('foo', 'bar');
-          context.report(node, ERROR_MESSAGE_GET_PROPERTIES);
+          context.report({ node, message: ERROR_MESSAGE_GET_PROPERTIES });
         }
 
         if (
@@ -274,7 +274,7 @@ module.exports = {
           validateGetPropertiesArguments(node.arguments.slice(1), ignoreNestedPaths)
         ) {
           // Example: getProperties(this, 'foo', 'bar');
-          context.report(node, ERROR_MESSAGE_GET_PROPERTIES);
+          context.report({ node, message: ERROR_MESSAGE_GET_PROPERTIES });
         }
       },
     };

diff --git a/lib/rules/no-global-jquery.js b/lib/rules/no-global-jquery.js
@@ -30,7 +30,7 @@ module.exports = {
         const tracker = new ReferenceTracker(context.getScope());
 
         for (const { node } of tracker.iterateGlobalReferences(globalMap)) {
-          context.report(node, ERROR_MESSAGE);
+          context.report({ node, message: ERROR_MESSAGE });
         }
       },
     };

diff --git a/lib/rules/no-incorrect-calls-with-inline-anonymous-functions.js b/lib/rules/no-incorrect-calls-with-inline-anonymous-functions.js
@@ -36,7 +36,7 @@ module.exports = {
     function checkArgumentsForInlineFunction(node) {
       for (const [index, argument] of node.arguments.entries()) {
         if (types.isAnyFunctionExpression(argument)) {
-          context.report(node.arguments[index], ERROR_MESSAGE);
+          context.report({ node: node.arguments[index], message: ERROR_MESSAGE });
         }
       }
     }

diff --git a/lib/rules/no-incorrect-computed-macros.js b/lib/rules/no-incorrect-computed-macros.js
@@ -66,7 +66,7 @@ module.exports = {
               },
             });
           } else if (node.arguments.length === 0) {
-            context.report(node, ERROR_MESSAGE_AND_OR);
+            context.report({ node, message: ERROR_MESSAGE_AND_OR });
           }
         }
       },

diff --git a/lib/rules/no-jquery.js b/lib/rules/no-jquery.js
@@ -27,7 +27,7 @@ module.exports = {
 
   create(context) {
     const report = function (node) {
-      context.report(node, ERROR_MESSAGE);
+      context.report({ node, message: ERROR_MESSAGE });
     };
 
     return {

diff --git a/lib/rules/no-legacy-test-waiters.js b/lib/rules/no-legacy-test-waiters.js
@@ -39,7 +39,7 @@ module.exports = {
           node.callee.type === 'Identifier' &&
           testWaitersIdentifiers.includes(node.callee.name)
         ) {
-          context.report(node, ERROR_MESSAGE);
+          context.report({ node, message: ERROR_MESSAGE });
         }
       },
     };

diff --git a/lib/rules/no-mixins.js b/lib/rules/no-mixins.js
@@ -27,7 +27,7 @@ module.exports = {
       ImportDeclaration(node) {
         const importPath = node.source.value;
         if (mixinPathRegex.test(importPath)) {
-          context.report(node, ERROR_MESSAGE);
+          context.report({ node, message: ERROR_MESSAGE });
         }
       },
     };

diff --git a/lib/rules/no-new-mixins.js b/lib/rules/no-new-mixins.js
@@ -27,13 +27,13 @@ module.exports = {
     return {
       CallExpression(node) {
         if (ember.isEmberMixin(context, node)) {
-          context.report(node, ERROR_MESSAGE);
+          context.report({ node, message: ERROR_MESSAGE });
         }
       },
 
       ClassDeclaration(node) {
         if (ember.isEmberMixin(context, node)) {
-          context.report(node, ERROR_MESSAGE);
+          context.report({ node, message: ERROR_MESSAGE });
         }
       },
     };