Skip to content

Commit

Permalink
Move gjs/gts parser to ember-eslint-parser library (#2028)
Browse files Browse the repository at this point in the history
* Add parser package

* Remove parser code because it'll be in ember-eslint-parser

* Update parser references

* Remove dependencies that will be provided by ember-eslint-parser

* Use parser

appease the linter for now

More lints

Not enough lint:fix

Use published version

bump version

eh

ohe

* Update dep locations

* Move to devdeps

* Delete the noop preprocessor

* All tests pass now

* lint:fix

* Link to other repo (the parser)
  • Loading branch information
NullVoxPopuli authored Dec 22, 2023
1 parent 4217189 commit ca54d94
Show file tree
Hide file tree
Showing 14 changed files with 97 additions and 926 deletions.
6 changes: 4 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,8 @@ learn more [here](https://github.com/ember-template-imports/ember-template-impor
> [!NOTE]
> special care should be used when setting up parsers, since they cannot be overwritten. thus they should be used in override only and specific to file types
gjs/gts support is provided by the [ember-eslint-parser](https://github.com/NullVoxPopuli/ember-eslint-parser)

```js
// .eslintrc.js
module.exports = {
Expand All @@ -81,7 +83,7 @@ module.exports = {
},
{
files: ['**/*.gts'],
parser: 'eslint-plugin-ember/gjs-gts-parser',
parser: 'ember-eslint-parser',
plugins: ['ember'],
extends: [
'eslint:recommended',
Expand All @@ -91,7 +93,7 @@ module.exports = {
},
{
files: ['**/*.gjs'],
parser: 'eslint-plugin-ember/gjs-gts-parser',
parser: 'ember-eslint-parser',
plugins: ['ember'],
extends: [
'eslint:recommended',
Expand Down
2 changes: 1 addition & 1 deletion lib/config-legacy/base.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ module.exports = {
*/
{
files: ['**/*.{gts,gjs}'],
parser: 'eslint-plugin-ember/gjs-gts-parser',
parser: 'ember-eslint-parser',
processor: 'ember/<noop>',
},
],
Expand Down
2 changes: 1 addition & 1 deletion lib/config/base.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ module.exports = [
*/
{
files: ['**/*.{gts,gjs}'],
parser: 'eslint-plugin-ember/gjs-gts-parser',
parser: 'ember-eslint-parser',
processor: 'ember/<noop>',
},
];
2 changes: 1 addition & 1 deletion lib/index.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
'use strict';

const requireIndex = require('requireindex');
const noop = require('./preprocessors/noop');
const noop = require('ember-eslint-parser/noop');
const pkg = require('../package.json'); // eslint-disable-line import/extensions

module.exports = {
Expand Down
59 changes: 0 additions & 59 deletions lib/parsers/gjs-gts-parser.js

This file was deleted.

Loading

0 comments on commit ca54d94

Please sign in to comment.