Add autofixer to no-get rule
#577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking for feedback on whether there's interest in this autofixer despite the unsafe situations mentioned above. |
|
Can you detect the simple version of the two caveats (like if |
This was referenced Nov 9, 2019
Adds an autofixer to help with the adoption of this rule. There is already a codemod (https://github.com/rondale-sc/es5-getter-ember-codemod) for this but the autofixer is more accessible.
|
Awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an autofixer to help with the adoption of this rule. There is already a codemod for this but the autofixer is more accessible.
I recently updated the rule to eliminate some false positives (#580 #581) and thus safely enable adding this autofixer.