Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update no-get rule to ignore get() usages inside proxy objects #580

Merged
merged 2 commits into from
Nov 9, 2019
Merged

Update no-get rule to ignore get() usages inside proxy objects #580

merged 2 commits into from
Nov 9, 2019

Commits on Nov 9, 2019

  1. chore: add util functions for detecting proxy objects

    @bmish
    bmish committed Nov 9, 2019
    Configuration menu
    Copy the full SHA
    4cfc70e View commit details
    Browse the repository at this point in the history

  2. fix: update no-get rule to ignore get() usages inside proxy objects 

    `get()` is still needed inside proxy objects.

This fix will help avoid false positives and enable future autofixing.

More info:
* https://github.com/emberjs/rfcs/blob/master/text/0281-es5-getters.md
* emberjs/ember.js#16148
    @bmish
    bmish committed Nov 9, 2019
    Configuration menu
    Copy the full SHA
    ac6f2ef View commit details
    Browse the repository at this point in the history