-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent erroring for newer non-SemVer watchman versions #13
Conversation
@rwjblue should we also deprecate the versions of node we support? |
Have to otherwise tests will fail |
I updated the nodejs versions to use the supported versions. cc @rwjblue @nlfurniss |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gabrielcsapo can you explain the solution? It looks like this PR just removes the version check. Assuming that's correct, can you explain why it's now ok to not check the version?
Hmm, if we couple this with a major bump we'll not be able to get the fix out to folks using currently supported ember-cli versions. @gabrielcsapo - What triggered the |
|
@rwjblue I believe CI was failing due to an engine update in a downstream dependency. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just rebased and updated this PR, it should not require a major bump.
Thank you @rwjblue ! |
fixes #12