Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent erroring for newer non-SemVer watchman versions #13

Merged
merged 1 commit into from
Jun 7, 2021
Merged

Prevent erroring for newer non-SemVer watchman versions #13

merged 1 commit into from
Jun 7, 2021

Conversation

gabrielcsapo
Copy link
Contributor

fixes #12

@gabrielcsapo
Copy link
Contributor Author

@rwjblue should we also deprecate the versions of node we support?

@nlfurniss
Copy link

nlfurniss commented Jun 4, 2021

@rwjblue should we also deprecate the versions of node we support?

Have to otherwise tests will fail ☹️ . And you're bumping the version anyway

@gabrielcsapo
Copy link
Contributor Author

I updated the nodejs versions to use the supported versions. cc @rwjblue @nlfurniss

.travis.yml Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
lib/index.js Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@gabrielcsapo gabrielcsapo changed the title bug] newer versions of watchman are not being used. Remove the guard for watchman versions [bug] newer versions of watchman are not being used. Remove the guard for watchman versions Jun 4, 2021
Copy link

@asakusuma asakusuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gabrielcsapo can you explain the solution? It looks like this PR just removes the version check. Assuming that's correct, can you explain why it's now ok to not check the version?

package.json Outdated Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
lib/index.js Show resolved Hide resolved
@gabrielcsapo gabrielcsapo requested a review from rwjblue June 4, 2021 23:42
@rwjblue
Copy link
Member

rwjblue commented Jun 7, 2021

Hmm, if we couple this with a major bump we'll not be able to get the fix out to folks using currently supported ember-cli versions.

@gabrielcsapo - What triggered the node engines change? Just basic cleanup stuff, or something specific?

@chriskrycho
Copy link

@nlfurniss noted above:

Have to otherwise tests will fail ☹️ . And you're bumping the version anyway

@scalvert
Copy link

scalvert commented Jun 7, 2021

@rwjblue I believe CI was failing due to an engine update in a downstream dependency.

Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just rebased and updated this PR, it should not require a major bump.

@rwjblue rwjblue changed the title [bug] newer versions of watchman are not being used. Remove the guard for watchman versions Prevent erroring for newer non-SemVer watchman versions Jun 7, 2021
@gabrielcsapo
Copy link
Contributor Author

Thank you @rwjblue !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] newer versions of watchman are not being used
7 participants