Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest master failing for Ember 4.0 Canary #844

Closed
simonihmig opened this issue Aug 11, 2021 · 1 comment
Closed

Latest master failing for Ember 4.0 Canary #844

simonihmig opened this issue Aug 11, 2021 · 1 comment

Comments

@simonihmig
Copy link
Contributor

I used the latest master version to make an addon work FastBoot and with Ember 4.0. However the changes in #841 seem to have caused a regression. Getting this:

Error: Assertion Failed: Cannot override the computed property `_fastbootInfo` on <dummy@service:fastboot::ember108>.
    at assert (/var/folders/q3/yzggf_l965zbzps_bk8xr37c0000gn/T/broccoli-13311v3tusXn4uAae/out-330-append_ember_auto_import_analyzer/assets/@ember/debug/index.js:178:1)
    at ComputedProperty.set (/var/folders/q3/yzggf_l965zbzps_bk8xr37c0000gn/T/broccoli-13311v3tusXn4uAae/out-330-append_ember_auto_import_analyzer/assets/@ember/-internals/metal/index.js:1513:1)
    at initialize (/var/folders/q3/yzggf_l965zbzps_bk8xr37c0000gn/T/broccoli-13311v3tusXn4uAae/out-330-append_ember_auto_import_analyzer/assets/@ember/-internals/runtime/lib/system/core_object.js:104:1)
    at Function.create (/var/folders/q3/yzggf_l965zbzps_bk8xr37c0000gn/T/broccoli-13311v3tusXn4uAae/out-330-append_ember_auto_import_analyzer/assets/@ember/-internals/runtime/lib/system/core_object.js:674:1)
    at FactoryManager.create (/var/folders/q3/yzggf_l965zbzps_bk8xr37c0000gn/T/broccoli-13311v3tusXn4uAae/out-330-append_ember_auto_import_analyzer/assets/@ember/-internals/container/index.js:527:1)
    at Proxy.create (/var/folders/q3/yzggf_l965zbzps_bk8xr37c0000gn/T/broccoli-13311v3tusXn4uAae/out-330-append_ember_auto_import_analyzer/assets/@ember/-internals/container/index.js:244:1)
    at instantiateFactory (/var/folders/q3/yzggf_l965zbzps_bk8xr37c0000gn/T/broccoli-13311v3tusXn4uAae/out-330-append_ember_auto_import_analyzer/assets/@ember/-internals/container/index.js:342:1)
    at lookup (/var/folders/q3/yzggf_l965zbzps_bk8xr37c0000gn/T/broccoli-13311v3tusXn4uAae/out-330-append_ember_auto_import_analyzer/assets/@ember/-internals/container/index.js:270:1)
    at Container.lookup (/var/folders/q3/yzggf_l965zbzps_bk8xr37c0000gn/T/broccoli-13311v3tusXn4uAae/out-330-append_ember_auto_import_analyzer/assets/@ember/-internals/container/index.js:139:1)
    at Class.lookup (/var/folders/q3/yzggf_l965zbzps_bk8xr37c0000gn/T/broccoli-13311v3tusXn4uAae/out-330-append_ember_auto_import_analyzer/assets/@ember/-internals/runtime/lib/mixins/container_proxy.js:81:1)
    at Class.getInjection (/var/folders/q3/yzggf_l965zbzps_bk8xr37c0000gn/T/broccoli-13311v3tusXn4uAae/out-330-append_ember_auto_import_analyzer/assets/@ember/-internals/metal/index.js:3561:1)
    at /var/folders/q3/yzggf_l965zbzps_bk8xr37c0000gn/T/broccoli-13311v3tusXn4uAae/out-330-append_ember_auto_import_analyzer/assets/@ember/-internals/metal/index.js:1480:1
    at untrack (/var/folders/q3/yzggf_l965zbzps_bk8xr37c0000gn/T/broccoli-13311v3tusXn4uAae/out-330-append_ember_auto_import_analyzer/assets/@glimmer/validator.js:836:1)
    at ComputedProperty.get (/var/folders/q3/yzggf_l965zbzps_bk8xr37c0000gn/T/broccoli-13311v3tusXn4uAae/out-330-append_ember_auto_import_analyzer/assets/@ember/-internals/metal/index.js:1479:1)
    at Class.getter [as fastboot] (/var/folders/q3/yzggf_l965zbzps_bk8xr37c0000gn/T/broccoli-13311v3tusXn4uAae/out-330-append_ember_auto_import_analyzer/assets/@ember/-internals/metal/index.js:1014:1)
    at getPossibleMandatoryProxyValue (/var/folders/q3/yzggf_l965zbzps_bk8xr37c0000gn/T/broccoli-13311v3tusXn4uAae/out-330-append_ember_auto_import_analyzer/assets/@ember/-internals/metal/index.js:1919:1)
    at _getProp (/var/folders/q3/yzggf_l965zbzps_bk8xr37c0000gn/T/broccoli-13311v3tusXn4uAae/out-330-append_ember_auto_import_analyzer/assets/@ember/-internals/metal/index.js:1984:1)
    at _getPath (/var/folders/q3/yzggf_l965zbzps_bk8xr37c0000gn/T/broccoli-13311v3tusXn4uAae/out-330-append_ember_auto_import_analyzer/assets/@ember/-internals/metal/index.js:2026:1)
    at get (/var/folders/q3/yzggf_l965zbzps_bk8xr37c0000gn/T/broccoli-13311v3tusXn4uAae/out-330-append_ember_auto_import_analyzer/assets/@ember/-internals/metal/index.js:1970:1)
    at Class.setURL (/var/folders/q3/yzggf_l965zbzps_bk8xr37c0000gn/T/broccoli-13311v3tusXn4uAae/out-330-append_ember_auto_import_analyzer/assets/addon-tree-output/ember-cli-fastboot/locations/none.js:24:1)
    at Class.superWrapper [as setURL] (/var/folders/q3/yzggf_l965zbzps_bk8xr37c0000gn/T/broccoli-13311v3tusXn4uAae/out-330-append_ember_auto_import_analyzer/assets/@ember/-internals/utils/index.js:432:1)
    at Class.visit (/var/folders/q3/yzggf_l965zbzps_bk8xr37c0000gn/T/broccoli-13311v3tusXn4uAae/out-330-append_ember_auto_import_analyzer/assets/@ember/application/instance.js:248:1)
    at EmberApp._visit (/Users/simonihmig/Projects/ember-bootstrap/node_modules/fastboot/src/ember-app.js:265:20)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at EmberApp.visit (/Users/simonihmig/Projects/ember-bootstrap/node_modules/fastboot/src/ember-app.js:325:7)
    at FastBoot.visit (/Users/simonihmig/Projects/ember-bootstrap/node_modules/fastboot/src/index.js:86:18)
    at /Users/simonihmig/Projects/ember-bootstrap/node_modules/fastboot-express-middleware/src/index.js:33:20

When pulling a previous commit (like 4ad4eeb) then this does not happen!

It seems this addon is not using the usual ember-try scenarios to test with different Ember versions, is that correct? 😯

cc @snewcomer

@gilest
Copy link

gilest commented May 6, 2023

This can be closed

@mansona mansona closed this as completed May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants