Avoid implicit injection _fastbootInfo deprecation #841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snewcomer
changed the title
xg-wang
reviewed
Aug 3, 2021
| @@ -88,6 +89,11 @@ const FastBootService = Service.extend({ | |||
| return RequestObject.create({ request: get(this, '_fastbootInfo.request') }); | |||
| }), | |||
|
|
|||
| _fastbootInfo: computed(function() { | |||
There was a problem hiding this comment.
Do we need the test changes in https://github.com/ember-fastboot/ember-cli-fastboot/pull/823/files? Specifically registering info:-fastboot in the container for later lookup.
There was a problem hiding this comment.
It doesn't look like it based on the tests passing! Do you see other value here?
snewcomer
force-pushed
the
sn/no-deprecation-implicit
branch
from
f89c712
to
2d89348
Compare
|
This is not really fixed. Adding ember-cli-fastboot 3.2.0-beta.3 to a new ember 3.27 app still results in the implicit injection deprecation message the first time you render in fastboot. I think code like this needs to go away: |
ef4
added a commit
that referenced
this pull request
Sep 10, 2021
This is required to clear the implicit-injection deprecation on Ember 3.27. This may need to be released as a semver major because this version of `fastboot` will only work with versions of `ember-cli-fastboot` after #841
|
@ef4 would a new schema version avoid breaking change? Essentially the attempt at https://github.com/ember-fastboot/ember-cli-fastboot/pull/823/files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in reference PR, the deprecation is issued when the FastBoot service is created. However, if we also register a property with the same name as the implicit injection (
app.inject('service:foo', 'store', 'some:object')), the deprecation goes away.close #819
ref https://github.com/ember-fastboot/ember-cli-fastboot/pull/823/files
rfc emberjs/rfcs#680