Update documentation on shoebox. #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
requested changes
May 6, 2020
README.md
Outdated
Comment on lines
449
to
450
| // must deep-copy for clean serialization. | ||
| return JSON.parse(JSON.stringify(result)); |
There was a problem hiding this comment.
Suggested change
| // must deep-copy for clean serialization. | |
| return JSON.parse(JSON.stringify(result)); | |
| // must deep-copy for clean serialization. | |
| return JSON.parse(JSON.stringify(result)); |
README.md
Outdated
Comment on lines
420
to
421
| the Application Adapter as shown below. | ||
| ``` |
There was a problem hiding this comment.
Suggested change
| the Application Adapter as shown below. | |
| ``` | |
| the Application Adapter as shown below. | |
| ```js |
README.md
Outdated
| the Application Adapter as shown below. | ||
| ``` | ||
| export default class ApplicationAdapter extends JSONAPIAdapter.extend( | ||
| ... |
There was a problem hiding this comment.
Suggested change
| ... | |
| // ...snip... |
|
@rwjblue updated per feedback |
|
LGTM! Thanks for doing this. @rwjblue does this look good to you? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes:
#761