-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add things about pnpm #290
Conversation
✅ Deploy Preview for ember-cli-guides ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
a172cd0
to
fd2a067
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but will need to wait to merge until release afaik
@kategengler since the 5.1 release happend, does that mean we can merge this PR now? Or did you mean another release :) |
pnpm is currently behind a feature flag and wouldn't have landed in 5.1 anyway, 5.2 is the earliest |
This lands in 5.3. Since the CLI guides aren't versioned, when should this merge? cc @MinThaMie |
I think this can merge the week of the 5.3 release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good to go, announced in the 5.3 blog post. Thank you!
RFC: emberjs/rfcs#907
Implementation PR: ember-cli/ember-cli#10287
Advancement: emberjs/rfcs#932
This PR should wait to be reviewed until the implementation PR is done.