Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add things about pnpm #290

Merged
merged 2 commits into from
Sep 22, 2023
Merged

Conversation

NullVoxPopuli
Copy link
Contributor

@NullVoxPopuli NullVoxPopuli commented Jun 7, 2023

RFC: emberjs/rfcs#907
Implementation PR: ember-cli/ember-cli#10287
Advancement: emberjs/rfcs#932

This PR should wait to be reviewed until the implementation PR is done.

@netlify
Copy link

netlify bot commented Jun 7, 2023

Deploy Preview for ember-cli-guides ready!

Name Link
🔨 Latest commit fd2a067
🔍 Latest deploy log https://app.netlify.com/sites/ember-cli-guides/deploys/6495e96b46353c0008803df4
😎 Deploy Preview https://deploy-preview-290--ember-cli-guides.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@NullVoxPopuli NullVoxPopuli marked this pull request as ready for review June 23, 2023 18:50
Copy link
Contributor

@kategengler kategengler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but will need to wait to merge until release afaik

@MinThaMie
Copy link
Contributor

@kategengler since the 5.1 release happend, does that mean we can merge this PR now? Or did you mean another release :)

@kategengler
Copy link
Contributor

pnpm is currently behind a feature flag and wouldn't have landed in 5.1 anyway, 5.2 is the earliest

@kategengler
Copy link
Contributor

This lands in 5.3. Since the CLI guides aren't versioned, when should this merge? cc @MinThaMie

@jenweber
Copy link
Contributor

jenweber commented Sep 2, 2023

I think this can merge the week of the 5.3 release.

Copy link
Contributor

@jenweber jenweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to go, announced in the 5.3 blog post. Thank you!

@jenweber jenweber merged commit 8e30cd9 into ember-learn:main Sep 22, 2023
@NullVoxPopuli NullVoxPopuli deleted the mention-pnpm branch September 22, 2023 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants