Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecations from Ember Data 5.x so far #1339

Merged
merged 7 commits into from
Sep 21, 2023

Conversation

Baltazore
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Aug 30, 2023

Deploy Preview for ember-deprecations ready!

Name Link
🔨 Latest commit 5faee08
🔍 Latest deploy log https://app.netlify.com/sites/ember-deprecations/deploys/650c9b4024e31c000869dd84
😎 Deploy Preview https://deploy-preview-1339--ember-deprecations.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@locks locks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't merge since the changes contain an unreleased deprecation

@Baltazore
Copy link
Contributor Author

@locks do you want me to split PR into 2 separate (one with 5.0 deprecation, another with 5.3 deprecations) ? Or this one can just wait until EData 5.3 would be released ?

@runspired
Copy link
Contributor

@locks this PR is happening now because @kategengler asked us to PR it and get url's prior to release. Sounds like there's a bit of a mixup somewhere in what's expected, we've never used urls for EmberData deprecations in the past but happy to use them going forward. From what I can tell they are predictable off of the file names in this PR so as long as there are no concerns about the file names I'll update the URLs in-advance in EmberData. Pattern: https://deprecations.emberjs.com/v5.x#toc_<fileName> e.g. https://deprecations.emberjs.com/v5.x#toc_ember-data-deprecate-legacy-imports because file is v5/ember-data-deprecate-legacy-imports.md

@kategengler
Copy link
Contributor

I really don't think there is any harm in showing deprecations for future versions in the deprecation guides. After all, users could be using the beta or canary. Though the guides should be written as if the deprecation is already released.

@runspired For URLs, since #1261 a URL scheme of https://deprecations.emberjs.com/id/<deprecation-id> is available, and, I think, preferable.

@Baltazore Thank you for PRing the deprecation guides.


Deprecates when importing from `ember-data/*` instead of `@ember-data/*` in order to prepare for the eventual removal of the legacy `ember-data/*`

All imports from `ember-data/*` should be updated to `@ember-data/*` except for `ember-data/store`. When you are using `ember-data` (as opposed to installing the individual packages) you should import from `ember-data/store` instead of `@ember-data/store` in order to receive the appropriate configuration of defaults.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a list of all imports we could show here?

@jaredgalanis
Copy link
Member

merging since we're all released now

@jaredgalanis jaredgalanis merged commit 431bf0a into ember-learn:main Sep 21, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants