Deprecation Guides Related To Router Service #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
rwjblue
reviewed
Oct 5, 2018
content/ember/v3/handler-infos.md
Outdated
| since: '3.7' | ||
| --- | ||
|
|
||
| `HandlerInfo` was a private API have been renamed to `RouteInfo` to align with the [router service RFC](https://github.com/emberjs/rfcs/blob/master/text/0095-router-service.md). If you need access to information about the routes, you are probably better served injecting the router service as it exposes a publically supported version of the `RouteInfo`s. You can access them in the following ways: |
There was a problem hiding this comment.
s/private API have been/private API that has been/
content/ember/v3/transition-state.md
Outdated
| id: transition-state | ||
| title: Transition State Removal | ||
| until: '3.9.0' | ||
| since: '3.7' |
content/ember/v3/router-events.md
Outdated
| id: deprecate-router-events | ||
| title: Deprecate Router Events | ||
| until: '4.0.0' | ||
| since: '3.7' |
content/ember/v3/handler-infos.md
Outdated
| id: remove-handler-infos | ||
| title: HandlerInfos Removal | ||
| until: '3.9.0' | ||
| since: '3.7' |
chadhietala
force-pushed
the
router-deprecations
branch
2 times, most recently
from
c10b0c4
to
9706f95
Compare
chadhietala
force-pushed
the
router-deprecations
branch
from
9706f95
to
72d861c
Compare
rwjblue
approved these changes
Oct 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds deprecation guides for the follow:
didTransitionandwillTransitionHandlerInfosintimate APITransition.state|params|queryParamsintimate API