Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blog(embertimes188): data first ember twitter #1031

Merged
merged 2 commits into from
Sep 10, 2021
Merged

blog(embertimes188): data first ember twitter #1031

merged 2 commits into from
Sep 10, 2021

Conversation

chrisrng
Copy link
Member

@chrisrng chrisrng commented Sep 9, 2021 •
edited
Loading

Ember Times review template

  • Add your name to top and bottom
  • Put emoji in writeup title
  • Add a short blurb (could be the title) to the beginning
  • Link to external article/repo/etc in paragraph/body text, not just the writeup title (link in writeup title is optional now)
  • Add the contributor in the post in format "FirstName LastName (@githubusername)" linked to their GitHub account
  • Check that all links work

What it does

Related Issue(s)

Sources

@chrisrng chrisrng requested a review from a team as a code owner September 9, 2021 21:30
@probot-autolabeler probot-autolabeler bot added the embertimes PR for an Ember Times issue label Sep 9, 2021
ijlee2
ijlee2 approved these changes Sep 10, 2021
View reviewed changes
Copy link
Member

@ijlee2 ijlee2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ijlee2 ijlee2 merged commit 84d5900 into blog/embertimes-188 Sep 10, 2021
@ijlee2 ijlee2 deleted the chrisrng-patch-1 branch September 10, 2021 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ijlee2 ijlee2 ijlee2 approved these changes

Assignees
No one assigned
Labels
embertimes PR for an Ember Times issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrisrng @ijlee2