Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Covered the release of ember-stereo #1032

Merged
merged 3 commits into from
Sep 10, 2021
Merged

Covered the release of ember-stereo #1032

merged 3 commits into from
Sep 10, 2021

Conversation

ijlee2
Copy link
Member

@ijlee2 ijlee2 commented Sep 10, 2021

Ember Times review template

  • Add your name to top and bottom
  • Put emoji in writeup title
  • Add a short blurb (could be the title) to the beginning
  • Link to external article/repo/etc in paragraph/body text, not just the writeup title (link in writeup title is optional now)
  • Add the contributor in the post in format "FirstName LastName (@githubusername)" linked to their GitHub account
  • Check that all links work

@ijlee2 ijlee2 requested a review from a team September 10, 2021 05:59
@probot-autolabeler probot-autolabeler bot added the embertimes PR for an Ember Times issue label Sep 10, 2021
@ijlee2 ijlee2 changed the base branch from main to blog/embertimes-188 September 10, 2021 05:59
@ijlee2
Copy link
Member Author

ijlee2 commented Sep 10, 2021

@jkeen If there's additional information that you want to provide, feel free to make a suggestion.

@jkeen
Copy link

jkeen commented Sep 10, 2021

@ijlee2 Thanks Isaac!

amyrlam
amyrlam approved these changes Sep 10, 2021
View reviewed changes
Copy link
Member

@amyrlam amyrlam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇‍♀️ thank you both, sounds super interesting!

@amyrlam amyrlam merged commit 054528f into blog/embertimes-188 Sep 10, 2021
@amyrlam amyrlam deleted the ember-stereo-release branch September 10, 2021 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkeen jkeen jkeen left review comments

@amyrlam amyrlam amyrlam approved these changes

Assignees
No one assigned
Labels
embertimes PR for an Ember Times issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ijlee2 @jkeen @amyrlam