Covered 1st Chennai EmberJS Meetup (Times issue 112) #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amyrlam
reviewed
Aug 22, 2019
amyrlam
reviewed
Aug 22, 2019
| @@ -23,6 +23,7 @@ You can read more about our general release process here: | |||
| Ember.js is the core framework for building ambitious web applications. | |||
|
|
|||
| ### Changes in Ember.js 3.12 | |||
|
|
|||
There was a problem hiding this comment.
not super impt, but remove this file?
There was a problem hiding this comment.
Hmm, you mean remove the file from the commit (not delete the file)? I think it's a good idea as it's not relevant to what I worked on. I noticed that the Travis build had failed because of linting. What should I do?
There was a problem hiding this comment.
oh gotcha. let's leave it. ugh maybe i should change that
amyrlam
approved these changes
Aug 22, 2019
Co-Authored-By: Amy Lam <[email protected]>
|
Thanks for your feedback and suggestions, Amy! |
|
let's merge this in! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.