Ember Times #133: add community feedback from flashrecruit #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change should make CI green
|
shared that the PR is up in #support-ember-times ... also wanted to mention, i would ignore the builds, we can address in the parent branch |
amyrlam
approved these changes
Jan 30, 2020
There was a problem hiding this comment.
@EndangeredMassa i think it reads great, thank you, much appreciated!
i thought it might be easier to add a commit in this case, and because there was a bit of a delay on our end
i'm going to merge this in and we can make further edits off the main branch if that's ok!
|
Sounds good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This PR adds a section to the next edition of Ember Times that highlight's my company's use of Ember Octane. This is similar to a recent issue that highlighted Outdoorsy.
I followed the guidance as best as I could, but am happy to make any adjustments. Feel free to close this if it's not appropriate for publication.