Added a section on Community case highlight (issue 93) #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisrng
reviewed
Apr 11, 2019
| - [Documentations](https://guides.emberjs.com/release/) (71%) | ||
| - [Ember.js blog](https://blog.emberjs.com/) (54%) | ||
| - [RFCs](https://github.com/emberjs/rfcs) (52%) | ||
| - Code samples (51%) |
There was a problem hiding this comment.
Thoughts on linking to twiddle?
There was a problem hiding this comment.
I'm okay with both including the link and leaving as is.
I didn't include a link because code samples, to me, may be a part of a blog post or documentation. I wasn't sure what link would make a good representative, and hadn't thought about Ember Twiddle.
Thanks! I left the blurb empty in case @MinThaMie will give a summary in her introduction. What do you think, @MinThaMie and @chrisrng ? |
amyrlam
approved these changes
Apr 11, 2019
Co-Authored-By: ijlee2 <[email protected]>
Co-Authored-By: ijlee2 <[email protected]>
Co-Authored-By: ijlee2 <[email protected]>
jayjayjpg
approved these changes
Apr 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
I added a section highlighting the benefits of Ember community. I also added my name to the list of authors.
Related Issue(s)
The added section goes with issue 93 (#60).