Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cals video series part two #661

Merged
merged 3 commits into from
May 28, 2020

Conversation

roderickdevelopers
Copy link
Contributor

@roderickdevelopers roderickdevelopers commented May 27, 2020

PR for Cals second Video

@probot-autolabeler probot-autolabeler bot added the embertimes PR for an Ember Times issue label May 27, 2020
Copy link
Member

@ijlee2 ijlee2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The write-up overall was great. I appreciate your continuing to study Ember and help out with the Times!

Can you look at the suggestions and decide whether they are appropriate? I noticed that the Alex linter suggested that you don't use the word "easy." I'd try to look for a different word, or add an ignore comment, so that the CI will pass.

@roderickdevelopers
Copy link
Contributor Author

I think this should be all set now!! Alex linter passed this time. Changed "easy" to "simple". Thank you again for having me help with the ember times team! Really helps with learning Github and working with a team! 🎉

Copy link
Member

@amyrlam amyrlam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the writeup and the review!

i watched the video and make a couple edits directly to the branch. we can make further edits off the main branch if needed!

@amyrlam amyrlam merged commit a465a75 into ember-learn:blog/embertimes-150 May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
embertimes PR for an Ember Times issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants