Add RFCs re Test Directory Naming Unification and Router Service Refresh Method #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijlee2
reviewed
May 29, 2020
|
|
||
| <add your name to author list, top and bottom> | ||
| <add blurb and emoji to "SOME-INTRO-HERE"> | ||
| Note this `refresh` method would be different than the currently available `Route.prototype.refresh` method that refreshes only the refreshes whatever route you call it on and all routes “below” it in the route hierarchy. This newly proposesd method would refresh all routes. |
There was a problem hiding this comment.
I'm not familiar with the RFC so I wasn't sure what you meant by "only the refreshes whatever route ... in the route hierarchy." Is it possible to rephrase this part of the sentence? (If not, no worries.)
Can we fix the spelling from proposesd to proposed?
There was a problem hiding this comment.
thanks, taking a looksie at the RFC re: your comment 👀
There was a problem hiding this comment.
👍 really appreciate the writeups, thank you!
ijlee2
approved these changes
May 29, 2020
amyrlam
reviewed
May 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.