Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal to update Ember Times template #683

Merged
merged 2 commits into from
Jun 21, 2020
Merged

Conversation

amyrlam
Copy link
Member

@amyrlam amyrlam commented Jun 13, 2020

What it does

I was thinking the bottom of the email every week is a bit long and we could combine the sections, using the image as a visual separator. What do you think? Open to any and all suggestions!

//

Also, posted on Discord asking if we can get the Readers' Questions to autopost to our channel. Maybe @locks or @jayjayjpg owns this? (I cannot remember)

Part of: #577

@amyrlam amyrlam requested a review from a team June 13, 2020 03:23
@amyrlam amyrlam added the embertimes PR for an Ember Times issue label Jun 13, 2020
@ijlee2
Copy link
Member

ijlee2 commented Jun 13, 2020

I think we'll want to consider how the current and proposed sections will look in the upcoming blog redesign.

I checked on Docker what the proposed changes mean for the current blog. I noticed a large gap between paragraphs due to the Tomster image. It seemed like we have two sections and require the <img> element to appear first, partly to hide CSS not working well.

Screen Shot 2020-06-13 at 7 47 28 AM

I think it'd be good to give the group a week to see this PR and provide you with more feedback. If we decide to combine the two sections into one, I think it'd be good to update the header text into "Connect with us!" (or something else that is general like this).

@amyrlam
Copy link
Member Author

amyrlam commented Jun 15, 2020

I got the form from @jayjayjpg - thank you! 🙇‍♀️

//

@ijlee2 Thanks for chiming in!

Ah sorry about the CSS, hadn't even checked it locally.

I def like Connect with us regardless!

Right now seems like a lot of real estate for every issue at the bottom, when it's not super active. But this is just a proposal for discussion, strongly agree with what you suggested!

@jayjayjpg
Copy link
Contributor

I'm also up for shortening the bottom section as a Connect with us paragraph that you suggested!

@amyrlam
Copy link
Member Author

amyrlam commented Jun 19, 2020

What do you think?

IS:
image

@ijlee2
Copy link
Member

ijlee2 commented Jun 19, 2020

Looks good to me, thanks!

@abhilashlr
Copy link
Member

Looks good to me as well @amyrlam 🎉

Copy link
Contributor

@jayjayjpg jayjayjpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you for this ✨ update!

@amyrlam
Copy link
Member Author

amyrlam commented Jun 21, 2020

cool let's try it out, consider this a living document, we can change it!

@amyrlam amyrlam merged commit 20c5760 into master Jun 21, 2020
@amyrlam amyrlam deleted the amy/update-template branch June 21, 2020 19:33
amyrlam added a commit that referenced this pull request Jun 21, 2020
Bring in update from #683
@amyrlam amyrlam mentioned this pull request Jun 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
embertimes PR for an Ember Times issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants