Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blog(embertimes154): ember-stargate #697

Merged
merged 4 commits into from
Jun 25, 2020
Merged

blog(embertimes154): ember-stargate #697

merged 4 commits into from
Jun 25, 2020

Conversation

chrisrng
Copy link
Member

No description provided.

@chrisrng chrisrng requested a review from a team June 25, 2020 14:11
@probot-autolabeler probot-autolabeler bot added the embertimes PR for an Ember Times issue label Jun 25, 2020
ijlee2
ijlee2 approved these changes Jun 25, 2020
View reviewed changes
Copy link
Member

@ijlee2 ijlee2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, Chris. Thanks for the writeup!

The 1st suggestion is optional, but the other two (adding a new line) are required to get linting to pass.

@chrisrng
Copy link
Member Author

Looks good to me, Chris. Thanks for the writeup!

The 1st suggestion is optional, but the other two (adding a new line) are required to get linting to pass.

Thanks!

@ijlee2 ijlee2 merged commit 1725780 into blog/embertimes-154 Jun 25, 2020
@ijlee2 ijlee2 deleted the chrisrng-patch-1 branch June 25, 2020 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ijlee2 ijlee2 ijlee2 approved these changes

Assignees
No one assigned
Labels
embertimes PR for an Ember Times issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrisrng @ijlee2