Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Covered Aswathprabhu's blog post on reactivity #719

Merged
merged 1 commit into from
Jul 24, 2020
Merged

Covered Aswathprabhu's blog post on reactivity #719

merged 1 commit into from
Jul 24, 2020

Conversation

ijlee2
Copy link
Member

@ijlee2 ijlee2 commented Jul 24, 2020

No description provided.

@probot-autolabeler probot-autolabeler bot added the embertimes PR for an Ember Times issue label Jul 24, 2020
@ijlee2 ijlee2 requested a review from a team July 24, 2020 02:58
amyrlam
amyrlam approved these changes Jul 24, 2020
View reviewed changes
Copy link
Member

@amyrlam amyrlam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is awesome, thank you! 👏

@ijlee2 ijlee2 merged commit edad9d3 into ember-learn:blog/embertimes-157 Jul 24, 2020
@amyrlam
Copy link
Member

amyrlam commented Jul 25, 2020

@ijlee2 there are a lot of oddities with alex

in certain places, <!-- alex enable just --> appears. i tend to use <!-- alex ignore just -->, which just ignores the paragraph below it

image

one day™️ need to learn more about alex and try to fix some of the quirks

just sharing for context, use alex ignore when possible!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyrlam amyrlam amyrlam approved these changes

Assignees
No one assigned
Labels
embertimes PR for an Ember Times issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ijlee2 @amyrlam