-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
a11y update #755
a11y update #755
Conversation
Co-authored-by: Isaac Lee <[email protected]>
|
||
<!-- alex ignore easy --> | ||
|
||
The goal of application language support was to provide a mechanism for new Ember apps to pass [WCAG Success Criteria 3.1.1 - Language of Page](https://www.w3.org/TR/WCAG21/#language-of-page). To meet that goal, [Joseph Sumner](https://github.com/josephdsumner), [Jamie White](https://github.com/jgwhite), [Ava Wroten](https://github.com/hergaiety) and [Melanie Sumner](https://github.com/melsumner) authored [RFC 635](https://emberjs.github.io/rfcs/0635-ember-new-lang.html), which proposed a `--lang` flag for `ember-cli`. This flag would enable developers to declare the application's language while they were creating the app, allowing them to more easily meet this particular success criteria. This RFC was merged on June 12th; the feature itself, authored by [Joseph Sumner](https://github.com/josephdsumner) with help from [Rob Jackson](https://github.com/rwjblue), was merged on August 24th. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question:
I noticed that you added th
to a date. I wondered if this helps screen readers pronounce the right word.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's an interesting question, but I don't think I know the answer off the top of my head. I'll need to check. 👍🏻
Co-authored-by: Isaac Lee <[email protected]>
Co-authored-by: Isaac Lee <[email protected]>
Co-authored-by: Isaac Lee <[email protected]>
|
||
[Benjamin Jegard](https://github.com/kamikillerto) created the [Ember Context Id Helper addon](https://github.com/KamiKillertO/ember-context-id-helper). The `{{context-id}}` generates a unique `id` for a given context. Because it uses the ember guidFor function under the hood, it will always return the same `id` for the same context. A use case for `context-id` helper is to programmatically associate `<label>`s and `<input>` element using the `<label>` `for` attribute and the `<input>`s `id` attribute. | ||
|
||
This addon took inspiration from the pre-RFC for the (guid-for) helper, which resulted in an [RFC for a new built-in template helper](https://github.com/steveszc/rfcs/blob/id-helper/text/0000-id-helper.md), authored by [Steve Szczecina](https://github.com/steveszc). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the parentheses came from Steve's use of them in the pre-RFC? I think double curly braces may better indicate a helper.
This addon took inspiration from the pre-RFC for the (guid-for) helper, which resulted in an [RFC for a new built-in template helper](https://github.com/steveszc/rfcs/blob/id-helper/text/0000-id-helper.md), authored by [Steve Szczecina](https://github.com/steveszc). | |
This addon took inspiration from the pre-RFC for the `{{guid-for}}` helper, which resulted in an [RFC for a new built-in template helper](https://github.com/steveszc/rfcs/blob/id-helper/text/0000-id-helper.md), authored by [Steve Szczecina](https://github.com/steveszc). |
Co-authored-by: Isaac Lee <[email protected]>
Co-authored-by: Isaac Lee <[email protected]>
Co-authored-by: Isaac Lee <[email protected]>
Co-authored-by: Isaac Lee <[email protected]>
|
||
## Thank You | ||
|
||
A huge thank you to all of the community members who participated in the Ember A11y Strike Team: [Abhilash Ramesh](https://github.com/abhilashlr), [Amy Lam](https://github.com/amyrlam), [Ava Wroten](https://github.com/hergaiety), [Benjamin Jegard](https://github.com/kamikillerto), [Emmanuel Patrick](https://github.com/the-bionic), [Eric Kelly](https://github.com/HeroicEric), [Frédéric Soumaré](https://github.com/hakilebara), [Jamie White](https://github.com/jgwhite), [Jen Weber](https://github.com/jenweber), [John Costanzo](https://github.com/jrock2004), [Joseph Sumner](https://github.com/josephdsumner), [Lennex Zinyando](https://github.com/zinyando), [Lenora Porter](https://github.com/lenoraporter), [Melanie Sumner](https://github.com/melsumner), [Praskovia Root](https://github.com/praskovia-root), [Rajasegar Chandran](https://github.com/rajasegar), [Robert Jackson](https://github.com/rwjblue), [Steve Szczecina](https://github.com/steveszc), and [Seema Shariat](https://github.com/seemajune). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💛
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for writing the article on what the A11y Strike Team has done since March and plan to do in the near future. It was very informative, although, at a few times, I wished that the paragraphs could be shorter (I'm sure this could be done with more time for revisions).
I think the article is good to go. If you have a bit more time, towards the end of the article, will you consider enumerating a list of major things that directly impact developers (e.g. RFCs, lint rules, new sections to the Ember Guides)? Because the article is long, I thought making a summary of key things would be good.
Thanks again for your help with the article and Strike Team!
I think that's a great idea! I'll try to add it and see how it goes. 👍🏻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MelSumner I think it looks absolutely wonderful!
blog post to provide an update on the Ember A11y Working Group.