Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not GDPR compliant out of the box #1415

Closed
mixonic opened this issue Apr 10, 2023 · 4 comments · Fixed by #1421
Closed

Not GDPR compliant out of the box #1415

mixonic opened this issue Apr 10, 2023 · 4 comments · Fixed by #1421

Comments

@mixonic
Copy link
Contributor

mixonic commented Apr 10, 2023

Addon docs uses Google fonts via

return `<link href="https://fonts.googleapis.com/css?family=Crimson+Text:400,600" rel="stylesheet">`;

As Google may use their fonts service to analyze user behavior (at the least gathering IP addresses), and there is no clear way for a user to opt-out, addon docs websites may not be GDPR compliant out of the box.

This could be resolved by having the site serve the font asset, not using a custom font at all, or by finding a GDPR compliant font hosting service.

At the least, a documented workaround should be available.

@mixonic
Copy link
Contributor Author

mixonic commented Apr 10, 2023

@SergeAstapov @RobbieTheWagner @miguelcobain I'm happy to solve this any of a few ways if you can give me a rough approval for what you think reasonable. Options available seem like:

  1. Add a build-time configuration that allows users to disable the font link. Add this to the docs. (requires a minor release)
  2. Change the default fonts to be appropriate system serif/sans fonts, and describe in the docs how to set a custom font. (would be a major release)
  3. Download and check the font into the assets of the theme so they come from the same domain instead of Google. (requires a minor release)

@RobbieTheWagner
Copy link
Member

@mixonic addon docs is mostly unmaintained now, since it won't work with v2 addons, embroider, or fastboot. If anyone wants to put in some time to help with those things, I would love to keep it going, but as of right now, there isn't really a path forward.

@mixonic
Copy link
Contributor Author

mixonic commented Apr 10, 2023

@RobbieTheWagner I'll keep that in mind, but I'd still love to address this issue upstream instead of forking for it. I'll take your vote as "do the least effort thing unless you are fixing one of these other three issues as well".

@RobbieTheWagner
Copy link
Member

Yeah, that's an accurate assessment. I'm fine with any fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants