Swap out 3rd party font for system fonts #1421
Conversation
Ember CLI Addon Docs should use system fonts by default. System fonts load quickly for users, reduce the site's coupling to 3rd party assets, and make sites privacy-friendly by default. The Google font previously relied upon would result in Google having the ability to add cookies for that traffic, possibly placing a site out of compliance with EU and other regulations regardin user tracking without consent processes in place.
To avoid loading fonts from a 3rd party domain, adopt a change in an upstream PR. ember-learn/ember-cli-addon-docs#1421
|
I'm taking the initiative to land this based on the consensus that any solution was acceptable expressed at #1415. Ping me if there is anything to follow up on! I'll look into triggering a release in the next day or two. |
| '"Palentino Linotype"', | ||
| '"URW Palladio L"', | ||
| '"P052"', | ||
| 'serif', |
There was a problem hiding this comment.
With serif fallback, it should work pretty much anywhere, but still - maybe its worth adding a windows font to the fallback list ?
There was a problem hiding this comment.
Per modern font stacks, Palatino Linotype is available on Windows XP and up.
I did not even see this PR before it was merged. It all seems fine to me, but would have been nice to check it out at least before merging. |
|
@RobbieTheWagner I haven't been able to make a release cut yet, so please feel free to provide feedback and I will address it! I'm also blocked on making a release until I'm granted permissions on the npm package, if you can unblock that. (@dfreeman was going to help me out) |
Ember CLI Addon Docs should use system fonts by default. System fonts load quickly for users, reduce the site's coupling to 3rd party assets, and make sites privacy-friendly by default.
The Google font previously relied upon would result in Google having the ability to add cookies for that traffic, possibly placing a site out of compliance with EU and other regulations regarding user tracking without consent processes in place.
Here I've replaced (via Addepar/ember-table#983 for the purposes of illustration):
with
Note that the strategy of font stacks is to pick a class of font, so this will render differently on Linux vs. macOS, etc.
I'm not sure what kind of release this warrants, but I'm going to suggest minor. It is not a breaking change, though it is a visual change.
Fixes #1415