Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure AddonDocs doesn't break fastboot #187

Open
samselikoff opened this issue Jun 6, 2018 · 2 comments
Open

Ensure AddonDocs doesn't break fastboot #187

samselikoff opened this issue Jun 6, 2018 · 2 comments
Labels

Comments

@samselikoff
Copy link
Contributor

Tried upgrading Storefront's AddonDocs to latest version, still ran into errors.

Did some digging, found these:

Only solution was to ember install ember-fetch to Storefront (as a devDependency, so just for the dummy app). Seems weird/broken to me, but if this is the only solution we should add to the docs?

@samselikoff samselikoff added the bug label Jun 6, 2018
@dfreeman
Copy link
Contributor

dfreeman commented Jun 7, 2018

The issue seems to be a mismatch in expectations between ember-fetch and ember-cli-fastboot. The former uses the updateFastBootManifest hook to add a Node-compatible version of fetch to the build, but that hook is only ever invoked for top-level addons, not nested ones.

The only thing I immediately saw in the issue tracker was a semi-related issue about fastbootDependencies not being recursively discovered, where @kratiahuja suggested that that hook might provide an alternative. If it's not being recursively invoked itself, though, then I'm not sure how these pieces are actually supposed to fit together ¯\_(ツ)_/¯

@dfreeman
Copy link
Contributor

dfreeman commented Jun 7, 2018

I think tchak/ember-fetch-adapter#1 and ember-cli/ember-fetch#98 are two more recent examples of this popping up specifically due to updateFastBootManifest rather than the older fastbootDependencies issue

alexdiliberto added a commit to alexdiliberto/ember-transformicons that referenced this issue Jul 21, 2018
  - `ember-fastboot-addon-tests` to facilitate testing this addon within the context of a consuming fastboot app
  - `[email protected]` because of an [upstream compatibility issue](ember-learn/ember-cli-addon-docs#187) between `ember-cli-addon-docs` and `ember-cli-fastboot`

  - `eslint` direct dependency and instead just use the inherited dependency from `ember-cli-eslint` -> `broccoli-lint-eslint` -> `eslint`
  - `chalk`, `cross-env`, `mocha`, and `request` direct dependencies from the older fastboot test implementation using `ember-cli-addon-tests`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants