-
-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure AddonDocs doesn't break fastboot #187
Comments
The issue seems to be a mismatch in expectations between The only thing I immediately saw in the issue tracker was a semi-related issue about |
I think tchak/ember-fetch-adapter#1 and ember-cli/ember-fetch#98 are two more recent examples of this popping up specifically due to |
- `ember-fastboot-addon-tests` to facilitate testing this addon within the context of a consuming fastboot app - `[email protected]` because of an [upstream compatibility issue](ember-learn/ember-cli-addon-docs#187) between `ember-cli-addon-docs` and `ember-cli-fastboot` - `eslint` direct dependency and instead just use the inherited dependency from `ember-cli-eslint` -> `broccoli-lint-eslint` -> `eslint` - `chalk`, `cross-env`, `mocha`, and `request` direct dependencies from the older fastboot test implementation using `ember-cli-addon-tests`
Tried upgrading Storefront's AddonDocs to latest version, still ran into errors.
Did some digging, found these:
Import fetch from 'fetch'
not working w/ 3.2.8 ember-cli/ember-fetch#55Only solution was to
ember install ember-fetch
to Storefront (as a devDependency, so just for the dummy app). Seems weird/broken to me, but if this is the only solution we should add to the docs?The text was updated successfully, but these errors were encountered: