-
-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support v2 addon format #1164
Support v2 addon format #1164
Conversation
@SergeAstapov is this all that is required? Does moving an addon to V2 fix our issues with embroider compatibility or does this just work for ember-animated because it has the docs as a separate app from the tests? |
yes, as far as I can see working on
unfortunately no. There are some issues in the
exactly! the docs app in |
I will point out that for v2 addons this is only a convention and not a hard requirement. So this PR makes sense as a good default, but it would also be good to let addon authors set this path explicitly. |
@SergeAstapov @ef4 do we want to allow users to tweak the path as part of this PR or should we follow up later? I am fine either way. |
@rwwagner90 I'd like to introduce that ability in this PR. It should be relatively simple and no need to have multiple PRs to introduce such feature. @ef4 thank you for the idea making this configurable. Converted PR to draft for now. |
@rwwagner90 updated PR: let app = new EmberApp(defaults, {
'ember-cli-addon-docs': {
documentingAddonAt: '../addon',
addonSrcFolder: 'source',
}
}); |
The
src
folder is a the new convention for the location of the addon source code.This can be seen in Porting an Addon to V2 guide as well as part of new addon blueprint.
This was tested in ember-animation/ember-animated#397