embroider ready #1454
Merged
embroider ready #1454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@patricklx looks like CI is unhappy with proposed changes :/ |
|
@SergeAstapov try again |
|
Ah, lock file issue and linter... Will fix it later |
|
fixed lock file issue |
|
i had to move babel.config.js inside eslint.rc file as it was breaking embroider build. the comment said its only used for eslint, so... |
|
it should now all work |
ef4
approved these changes
Jun 27, 2023
SergeAstapov
approved these changes
Jun 27, 2023
|
Thanks @ef4 for chime in! |
RobbieTheWagner
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a way to support embroider and classic build.
as postprocessTree does not exists for embroider, alternative ways where needed.
The drawback.of this could be that if some other type of files would be converted to .md files, those would not be picked up.
And other files that could be converted to hbs files, e.g. emblem