Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ember-tether to dependencies #1485

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

barryofguilder
Copy link
Contributor

This adds ember-tether to the package "depencencies" and will fix #1484.

@barryofguilder
Copy link
Contributor Author

barryofguilder commented Sep 7, 2023

Hmm, with pnpm, I still get the following error unless the consuming test-app specifies ember-tether in it's dependencies. I'm not great with dependency resolution, so not sure what needs to be changed.

Screenshot 2023-09-07 at 12 33 37 PM

Edit: Should it be changed to be a peer dependency?

@RobbieTheWagner
Copy link
Member

@barryofguilder thanks for the PR! I think what you have here is correct because ember-tether is a peerDep of ember-modal-dialog. Let's try merging and releasing this and see if the released version works for you.

@RobbieTheWagner RobbieTheWagner merged commit 40e7b39 into ember-learn:master Sep 12, 2023
14 checks passed
@barryofguilder
Copy link
Contributor Author

@barryofguilder thanks for the PR! I think what you have here is correct because ember-tether is a peerDep of ember-modal-dialog. Let's try merging and releasing this and see if the released version works for you.

Yep, after installing this version, I was able to remove ember-tether from my test-app and it still worked.

@barryofguilder barryofguilder deleted the jb/deps branch September 12, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version dropdown doesn't work when using pnpm
2 participants