Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix compatibility with ember-data 5 #1517

Merged
merged 1 commit into from
Dec 21, 2023
Merged

fix compatibility with ember-data 5 #1517

merged 1 commit into from
Dec 21, 2023

Conversation

AmauryD
Copy link
Contributor

@AmauryD AmauryD commented Dec 20, 2023 •
edited
Loading

Fixes #1507

AmauryD
AmauryD commented Dec 20, 2023
View reviewed changes
addon/models/module.js
classes;

@hasMany('class', { async: false, inverse: null })
@hasMany('class', { async: false, inverse: null, polymorphic: true })
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If someone knowledgeable about this library comes across this, is it normal for 'components' to be a 'class' model rather than a 'component' model ?

SergeAstapov
SergeAstapov approved these changes Dec 20, 2023
View reviewed changes
Copy link
Collaborator

@SergeAstapov SergeAstapov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

RobbieTheWagner
RobbieTheWagner approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@RobbieTheWagner RobbieTheWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me, thanks for the fix!

@RobbieTheWagner RobbieTheWagner merged commit 191d51b into ember-learn:master Dec 21, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobbieTheWagner RobbieTheWagner RobbieTheWagner approved these changes

@SergeAstapov SergeAstapov SergeAstapov approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error from ember data with the module model
3 participants
@AmauryD @SergeAstapov @RobbieTheWagner