Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use double quotes everywhere #433

Merged
merged 1 commit into from
Dec 9, 2019
Merged

Use double quotes everywhere #433

merged 1 commit into from
Dec 9, 2019

Conversation

ctjhoa
Copy link
Contributor

@ctjhoa ctjhoa commented Dec 9, 2019

This PR replace all single quotes to double quotes.

Why?

  • It wasn't consistent across this project
  • Ember app comes with double quotes by default
  • You can't copy paste examples without introducing linting errors in a new App

@RobbieTheWagner
Copy link
Member

@ctjhoa I think we need to also update some tests?

@ctjhoa
Copy link
Contributor Author

ctjhoa commented Dec 9, 2019

@ctjhoa I think we need to also update some tests?

Yeah I saw this...

@RobbieTheWagner RobbieTheWagner merged commit eab7693 into ember-learn:master Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobbieTheWagner RobbieTheWagner RobbieTheWagner approved these changes

Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ctjhoa @RobbieTheWagner